hw/pvrdma: Check the correct return value

Return value of 0 means ok, we want to free the memory only in case of error. Signed-off-by: Yuval Shaia <[email protected]> Message-Id: <[email protected]> Reviewed-by: Marcel Apfelbaum<[email protected]> Signed-off-by: Marcel Apfelbaum <[email protected]>
zhijianli88 · Dec 22, 2018 · dee2e53 · dee2e53
1 parent 891ff9f
commit dee2e53
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
@@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req *req,
                                      cmd->start, cmd->length, host_virt,
                                      cmd->access_flags, &resp->mr_handle,
                                      &resp->lkey, &resp->rkey);
-    if (host_virt && !resp->hdr.err) {
+    if (resp->hdr.err && host_virt) {
         munmap(host_virt, cmd->length);
     }