Skip to content

Commit

Permalink
Do not schedule the input or output streams in the runloop since they…
Browse files Browse the repository at this point in the history
… are used synchronously
  • Loading branch information
Brian King committed Mar 15, 2016
1 parent 5b6155c commit 34086ca
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions Source/MultipartFormData.swift
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ public class MultipartFormData {
throw Error.errorWithCode(NSURLErrorCannotOpenFile, failureReason: failureReason)
}

outputStream.scheduleInRunLoop(NSRunLoop.currentRunLoop(), forMode: NSDefaultRunLoopMode)
outputStream.open()

self.bodyParts.first?.hasInitialBoundary = true
Expand All @@ -439,7 +438,6 @@ public class MultipartFormData {
}

outputStream.close()
outputStream.removeFromRunLoop(NSRunLoop.currentRunLoop(), forMode: NSDefaultRunLoopMode)
}

// MARK: - Private - Body Part Encoding
Expand Down Expand Up @@ -476,7 +474,6 @@ public class MultipartFormData {

private func encodeBodyStreamDataForBodyPart(bodyPart: BodyPart) throws -> NSData {
let inputStream = bodyPart.bodyStream
inputStream.scheduleInRunLoop(NSRunLoop.currentRunLoop(), forMode: NSDefaultRunLoopMode)
inputStream.open()

var error: NSError?
Expand All @@ -503,7 +500,6 @@ public class MultipartFormData {
}

inputStream.close()
inputStream.removeFromRunLoop(NSRunLoop.currentRunLoop(), forMode: NSDefaultRunLoopMode)

if let error = error {
throw error
Expand Down Expand Up @@ -537,7 +533,6 @@ public class MultipartFormData {

private func writeBodyStreamForBodyPart(bodyPart: BodyPart, toOutputStream outputStream: NSOutputStream) throws {
let inputStream = bodyPart.bodyStream
inputStream.scheduleInRunLoop(NSRunLoop.currentRunLoop(), forMode: NSDefaultRunLoopMode)
inputStream.open()

while inputStream.hasBytesAvailable {
Expand All @@ -563,7 +558,6 @@ public class MultipartFormData {
}

inputStream.close()
inputStream.removeFromRunLoop(NSRunLoop.currentRunLoop(), forMode: NSDefaultRunLoopMode)
}

private func writeFinalBoundaryDataForBodyPart(
Expand Down

0 comments on commit 34086ca

Please sign in to comment.