Skip to content

Commit

Permalink
usb: ohci: fix error return code in servicing iso td
Browse files Browse the repository at this point in the history
It should return 1 if an error occurs when reading iso td.
This will avoid an infinite loop issue in ohci_service_ed_list.

Signed-off-by: Li Qiang <[email protected]>
Message-id: [email protected]
Signed-off-by: Gerd Hoffmann <[email protected]>
  • Loading branch information
Li Qiang authored and kraxel committed Feb 21, 2017
1 parent d710e1e commit 26f670a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/usb/hcd-ohci.c
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed,
if (ohci_read_iso_td(ohci, addr, &iso_td)) {
trace_usb_ohci_iso_td_read_failed(addr);
ohci_die(ohci);
return 0;
return 1;
}

starting_frame = OHCI_BM(iso_td.flags, TD_SF);
Expand Down

0 comments on commit 26f670a

Please sign in to comment.