Optimize xeokit PerformanceModel#destroy()

xeokit/xeokit-sdk#194
zhy1440 · Nov 4, 2019 · d70cfb5 · d70cfb5
1 parent b6d8c73
commit d70cfb5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/xeokit/viewer/scene/PerformanceModel/lib/PerformanceNode.js b/lib/xeokit/viewer/scene/PerformanceModel/lib/PerformanceNode.js
@@ -529,7 +529,7 @@ class PerformanceNode {
         if (this._isObject) {
             scene._deregisterObject(this);
             if (this.visible) {
-                scene._objectVisibilityUpdated(this);
+                scene._objectVisibilityUpdated(this, false);
             }
             if (this.xrayed) {
                 scene._objectXRayedUpdated(this);

diff --git a/lib/xeokit/viewer/scene/scene/Scene.js b/lib/xeokit/viewer/scene/scene/Scene.js
@@ -905,14 +905,16 @@ class Scene extends Component {
         this._objectIds = null; // Lazy regenerate
     }
 
-    _objectVisibilityUpdated(entity) {
+    _objectVisibilityUpdated(entity, notify=true) {
         if (entity.visible) {
             this.visibleObjects[entity.id] = entity;
         } else {
             delete this.visibleObjects[entity.id];
         }
         this._visibleObjectIds = null; // Lazy regenerate
-        this.fire("objectVisibility", entity, true);
+        if (notify) {
+            this.fire("objectVisibility", entity, true);
+        }
     }
 
     _objectXRayedUpdated(entity) {