Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a section which is setting missing libraries for build and test #107

Open
wants to merge 2 commits into
base: email-recovery
Choose a base branch
from

Conversation

wshino
Copy link
Contributor

@wshino wshino commented Feb 6, 2025

Description

Related issue is here

This PR updates the setup documentation for the latest foundry-zksync

Before, when using foundry-zksync, it was necessary to deploy missing libraries in advance
Without this, neither unit tests nor integration tests could run

However, in the latest version, missing libraries are automatically detected and deployed
Because of this, both building and testing now work just like normal Foundry

Thus, I removed the section about setting missing libraries from the docs

However, setting missing libraries is still necessary for deployment

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wshino wshino changed the title chore: use anvil-zksync instead of era_test_node Remove a section which is setting missing libraries for build and test Feb 6, 2025
@wshino wshino marked this pull request as ready for review February 6, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant