feat: rebuild circuits if circuits_dir changes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxkzmn
reviewed
Jan 22, 2025
| .arg(witnesscalc_build_target) | ||
| .current_dir(&witnesscalc_path) | ||
| .spawn() | ||
| .expect("Failed to spawn make arm64_host") |
There was a problem hiding this comment.
There are a few old error messages here with hardcoded "arm64_host" that we can rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
println!("cargo:rerun-if-changed={}", circuits_dir.to_string());to detect ifcircuits_dirchanges and rerunrust-witnessmopro#298 if it is not rebuiltgmpwill not be rebuilt if it has been builtlitwitnesscalc_{CIRCUIT_NAME}.a, we cannot know whether the cpp file is changed (!?)circuits_dirchanges