Skip to content

Commit

Permalink
Add warning about the use of fingerprint on signature verification me…
Browse files Browse the repository at this point in the history
…thod
  • Loading branch information
pitbulk committed Mar 5, 2018
1 parent 54d1489 commit 2992d88
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ and supported by OneLogin Inc.
Warning
-------

php-saml is not affected by [201803-01](https://simplesamlphp.org/security/201803-01)

Update php-saml to 2.10.4, this version includes a security patch related to
[signature validations on LogoutRequests/LogoutResponses](https://github.com/onelogin/php-saml/commit/949359f5cad5e1d085c4e5447d9aa8f49a6e82a1)

Expand Down Expand Up @@ -157,6 +159,7 @@ In production, the `strict` parameter **MUST** be set as `"true"` and the
something other than SHA1 (see https://shattered.io/ ). Otherwise your
environment is not secure and will be exposed to attacks.

In production also we highly recommended to register on the settings the IdP certificate instead of using the fingerprint method. The fingerprint, is a hash, so at the end is open to a collision attack that can end on a siganture validation bypass. Other SAML toolkits deprecated that mechanism, we maintain it for compatibility and also to be used on test environment.

Getting started
---------------
Expand Down Expand Up @@ -379,7 +382,8 @@ $settings = array (
'x509cert' => '',
/*
* Instead of use the whole x509cert you can use a fingerprint in order to
* validate a SAMLResponse.
* validate a SAMLResponse, but we don't recommend to use that
* method on production since is exploitable by a collision attack.
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
* or add for example the -sha256 , -sha384 or -sha512 parameter)
*
Expand Down
5 changes: 4 additions & 1 deletion settings_example.php
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@
// Public x509 certificate of the IdP
'x509cert' => '',
/*
* Instead of use the whole x509cert you can use a fingerprint
* Instead of use the whole x509cert you can use a fingerprint in
* order to validate the SAMLResponse, but we don't recommend to use
* that method on production since is exploitable by a collision
* attack.
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
* or add for example the -sha256 , -sha384 or -sha512 parameter)
*
Expand Down

0 comments on commit 2992d88

Please sign in to comment.