Skip to content

Commit

Permalink
layers: Add IMG to robust buffer access check
Browse files Browse the repository at this point in the history
  • Loading branch information
pnyaa authored and jeremyg-lunarg committed Apr 8, 2022
1 parent 7546309 commit 3f848c7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions layers/best_practices_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -257,15 +257,15 @@ bool BestPractices::PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice,
"vkCreateDevice() called before getting physical device features from vkGetPhysicalDeviceFeatures().");
}

if ((VendorCheckEnabled(kBPVendorArm) || VendorCheckEnabled(kBPVendorAMD)) && (pCreateInfo->pEnabledFeatures != nullptr) &&
(pCreateInfo->pEnabledFeatures->robustBufferAccess == VK_TRUE)) {
if ((VendorCheckEnabled(kBPVendorArm) || VendorCheckEnabled(kBPVendorAMD) || VendorCheckEnabled(kBPVendorIMG)) &&
(pCreateInfo->pEnabledFeatures != nullptr) && (pCreateInfo->pEnabledFeatures->robustBufferAccess == VK_TRUE)) {
skip |= LogPerformanceWarning(
device, kVUID_BestPractices_CreateDevice_RobustBufferAccess,
"%s %s vkCreateDevice() called with enabled robustBufferAccess. Use robustBufferAccess as a debugging tool during "
"%s %s %s vkCreateDevice() called with enabled robustBufferAccess. Use robustBufferAccess as a debugging tool during "
"development. Enabling it causes loss in performance for accesses to uniform buffers and shader storage "
"buffers. Disable robustBufferAccess in release builds. Only leave it enabled if the application use-case "
"requires the additional level of reliability due to the use of unverified user-supplied draw parameters.",
VendorSpecificTag(kBPVendorArm), VendorSpecificTag(kBPVendorAMD));
VendorSpecificTag(kBPVendorArm), VendorSpecificTag(kBPVendorAMD), VendorSpecificTag(kBPVendorIMG));
}

return skip;
Expand Down

0 comments on commit 3f848c7

Please sign in to comment.