Skip to content

Commit

Permalink
Fix flakiness of BuildEventServiceTests
Browse files Browse the repository at this point in the history
The flakiness was caused by waiting for the server to receive the second
life-cycle event, but not waiting for the ack to get to the client. In that
case, the interruption would happen before the life-cycle call returned, in
which case it threw the InterruptedException, and then the stream doesn't
exist yet, and so there's no mechanism to send anything to the server.

PiperOrigin-RevId: 170472383
  • Loading branch information
ulfjack authored and katre committed Sep 29, 2017
1 parent 65959f5 commit 3dc2f54
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ public BuildEventServiceTransport(
this.sleeper = sleeper;
}

public boolean isStreaming() {
return besClient.isStreamActive();
}

@Override
public ListenableFuture<Void> close() {
return close(/*now=*/false);
Expand Down

0 comments on commit 3dc2f54

Please sign in to comment.