merge new version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetty 8 is a very old jetty version and the current widely used version is Jetty 9. If a user is using standalone Samza in a Jetty container, and he/she is using Jetty 9, he/she may see some incompatibility issue and it makes a lot of sense for a user to upgrade the Jetty version on his/her side instead of downgrading the Jetty version. Author: Fred Ji <[email protected]> Reviewers: Yi Pan <[email protected]> Closes #20 from fredji97/master
Disables a broken test in SamzaRest due to Jetty version upgrade in Samza. This is a temporary solution just to keep the build green on master. Longer term solution is to mock the Jetty objects properly through Mockito. Author: Shanthoosh Venkataraman <[email protected]> Reviewers: Yi Pan <[email protected]> Closes #26 from shanthoosh/master
Chooser always pools end of stream message until final callback is trigered so process-enelopes metrics didn't match. Changed the test methods to return null envelopes after end of stream message. Deleted unused boolean variable "completed" in AsyncTaskWorker Author: banecogic <[email protected]> Reviewers: Yi Pan <[email protected]> Closes #24 from banecogic/SAMZA-1047
Some suggestions for an Operator API refactor and misc. cleanup. It does contain some implementation changes, mostly due to deleted, extracted or merged classes. (e.g. OperatorFactory + ChainedOperators == OperatorImpls). Since git marked several moved classes as (delete + new) instead, it's probably best to apply the diff locally and browse the code in an IDE. Some of the changes, in no particular order: * Extracted XFunction interfaces into a .functions package in -api. * -api's internal.Operators is now the -operators's spec.* package. Extracted interfaces and classes. Factory methods are now in OperatorSpecs. * -api's MessageStreams is now -api's MessageStream interface and -operators's MessageStreamImpl. * -api's internal.Windows classes are now in -api's .window package. Extracted interfaces and classes, but no implementation changes. * OperatorFactory + ChainedOperators is now OperatorImpls, which is used from StreamOperatorAdaptorTask. * Added a NoOpOperatorImpl, which acts as the root node for the OperatorImpl DAG returned by OperatorImpls. * Removed usages of reactivestreams APIs since current code looks simpler without them. We can add them back when we need features like backpressure etc. * Removed the InputSystemMessage interface. * Made field names consistent (e.g Fn suffix for functions everywhere etc.). * Some method/class visibility changes due to moved classes. * General documentation changes, mostly to make public APIs clearer. There are additional questions/tasks that we can address in future RBs: * Updating Window and Trigger APIs. * Merging samza-operator into samza-core. * Questions about Message timestamp and Offset comparison semantics. * Questions about OperatorSpec serialization (e.g. ID generation). * Questions about StateStoreImpl and StoreFunctions. Author: Prateek Maheshwari <[email protected]> Reviewers: Yi Pan <[email protected]>, Jagadish <[email protected]> Closes #25 from prateekm/master
I setup a Jenkins Build Job to get triggered every time changes are pushed to samza repository. https://builds.apache.org/view/S-Z/view/Samza/job/samza-freestyle-build/ In case of build failures, it will send an email to devsamza.apache.org. We can customize this build as need arises. Author: Navina Ramesh <[email protected]> Reviewers: nickpan47 Closes #27 from navina/build-icon
SAMZA-1060. Allow to specify a changelog system separately, so user can only specify stream name for each store. If user specifies both (system and stream) it overwrites the job.changelog.system setting. Author: Boris Shkolnik <[email protected]> Reviewers: navina Closes #31 from sborya/master
Author: Boris Shkolnik <[email protected]> Reviewers: Jagadish <[email protected]> Closes #32 from sborya/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.