RHI: Make sure to compare bindings when comparing QShaders

It is possible, at least with Metal, that after the shader is converted to the native shader that the native bindings will changes, so it is important to also make a comparison against the bindings as well. Pick-to: 6.4 Change-Id: I8b6ff99fbda04ea66e3cb7970d7c33df066734cf Reviewed-by: Laszlo Agocs <[email protected]>
zoldalis · Aug 25, 2022 · e020a8e · e020a8e
1 parent 612c345
commit e020a8e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/gui/rhi/qshader.cpp b/src/gui/rhi/qshader.cpp
@@ -516,8 +516,8 @@ QShaderKey::QShaderKey(QShader::Source s,
 bool operator==(const QShader &lhs, const QShader &rhs) noexcept
 {
     return lhs.d->stage == rhs.d->stage
-            && lhs.d->shaders == rhs.d->shaders;
-    // do not bother with desc and bindings, if the shader code is the same, the description must match too
+            && lhs.d->shaders == rhs.d->shaders
+            && lhs.d->bindings == rhs.d->bindings;
 }
 
 /*!