Warn when loading Turbolinks from a <script> inside <body>

zolzaya · Jan 4, 2018 · b99e541 · b99e541
1 parent 704a514
commit b99e541
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/turbolinks/index.coffee b/src/turbolinks/index.coffee
@@ -3,6 +3,7 @@
 #= require_self
 #= require ./helpers
 #= require ./controller
+#= require ./script_warning
 #= require ./start
 
 @Turbolinks =

diff --git a/src/turbolinks/script_warning.coffee b/src/turbolinks/script_warning.coffee
@@ -0,0 +1,16 @@
+do ->
+  return unless element = script = document.currentScript
+  return if script.hasAttribute("data-turbolinks-suppress-warning")
+
+  while element = element.parentNode
+    if element is document.body
+      return console.warn """
+        You are loading Turbolinks from a <script> element inside the <body> element. This is probably not what you meant to do!
+
+        Load your application’s JavaScript bundle inside the <head> element instead. <script> elements in <body> are evaluated with each page change.
+
+        For more information, see: https://github.com/turbolinks/turbolinks#working-with-script-elements
+
+        ——
+        Suppress this warning by adding a `data-turbolinks-suppress-warning` attribute to: %s
+      """, script.outerHTML