Skip to content

Commit

Permalink
Add a FIXME for PR22796, broken ordering of ClassInfo in TableGen
Browse files Browse the repository at this point in the history
As discussed (at length) in code review of r222935, with Duncan.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@231282 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
dwblaikie committed Mar 4, 2015
1 parent 671944f commit 5109ec0
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions utils/TableGen/AsmMatcherEmitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,11 @@ struct ClassInfo {
}

/// operator< - Compare two classes.
// FIXME: This ordering seems to be broken. For example:
// u64 < i64, i64 < s8, s8 < u64, forming a cycle
// u64 is a subset of i64
// i64 and s8 are not subsets of each other, so are ordered by name
// s8 and u64 are not subsets of each other, so are ordered by name
bool operator<(const ClassInfo &RHS) const {
if (this == &RHS)
return false;
Expand Down

0 comments on commit 5109ec0

Please sign in to comment.