Fix a bug exposed by lli

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@3049 91177308-0d34-0410-b5e6-96231b3b80d8
zoren · Jul 24, 2002 · faba809 · faba809
1 parent e2c677f
commit faba809
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/lib/Support/CommandLine.cpp b/lib/Support/CommandLine.cpp
@@ -348,8 +348,17 @@ void cl::ParseCommandLineOptions(int &argc, char **argv,
     unsigned ValNo = 0;
     for (unsigned j = 1, e = PositionalOpts.size(); j != e; ++j)
       if (RequiresValue(PositionalOpts[j]))
-        ErrorParsing |=
-          ProvidePositionalOption(PositionalOpts[j], PositionalVals[ValNo++]);
+        ErrorParsing |= ProvidePositionalOption(PositionalOpts[j],
+                                                PositionalVals[ValNo++]);
+
+    // Handle the case where there is just one positional option, and it's
+    // optional.  In this case, we want to give JUST THE FIRST option to the
+    // positional option and keep the rest for the consume after.  The above
+    // loop would have assigned no values to positional options in this case.
+    //
+    if (PositionalOpts.size() == 2 && ValNo == 0)
+      ErrorParsing |= ProvidePositionalOption(PositionalOpts[1],
+                                              PositionalVals[ValNo++]);
 
     // Handle over all of the rest of the arguments to the
     // cl::ConsumeAfter command line option...

diff --git a/support/lib/Support/CommandLine.cpp b/support/lib/Support/CommandLine.cpp
@@ -348,8 +348,17 @@ void cl::ParseCommandLineOptions(int &argc, char **argv,
     unsigned ValNo = 0;
     for (unsigned j = 1, e = PositionalOpts.size(); j != e; ++j)
       if (RequiresValue(PositionalOpts[j]))
-        ErrorParsing |=
-          ProvidePositionalOption(PositionalOpts[j], PositionalVals[ValNo++]);
+        ErrorParsing |= ProvidePositionalOption(PositionalOpts[j],
+                                                PositionalVals[ValNo++]);
+
+    // Handle the case where there is just one positional option, and it's
+    // optional.  In this case, we want to give JUST THE FIRST option to the
+    // positional option and keep the rest for the consume after.  The above
+    // loop would have assigned no values to positional options in this case.
+    //
+    if (PositionalOpts.size() == 2 && ValNo == 0)
+      ErrorParsing |= ProvidePositionalOption(PositionalOpts[1],
+                                              PositionalVals[ValNo++]);
 
     // Handle over all of the rest of the arguments to the
     // cl::ConsumeAfter command line option...