Skip to content

Commit

Permalink
pinctrl: sirf: atlas7: Add missing of_node_put
Browse files Browse the repository at this point in the history
of_find_node_by_name does an of_node_get on its return value,
so an of_node_put is needed on this value before the corresponding
variable goes out of scope.

The Coccinelle semantic patch used to make this change is as follows:
@@
struct device_node *n;
struct device_node *n1;
statement S;
identifier f;
expression E;
constant C;
@@

n = of_find_node_by_name(...)
...
if (!n) S
... when != of_node_put(n)
    when != n1 = f(n,...)
    when != E = n
    when any
    when strict
(
+ of_node_put(n);
  return -C;
|
  of_node_put(n);
|
  n1 = f(n,...)
|
  E = n
|
  return ...;
)

Signed-off-by: Amitoj Kaur Chawla <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
  • Loading branch information
musicakc authored and linusw committed Jun 29, 2016
1 parent cc4fa83 commit 151b8c5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/pinctrl/sirf/pinctrl-atlas7.c
Original file line number Diff line number Diff line change
Expand Up @@ -5424,8 +5424,10 @@ static int atlas7_pinmux_probe(struct platform_device *pdev)
if (ret)
return ret;
pmx->sys2pci_base = devm_ioremap_resource(&pdev->dev, &res);
if (IS_ERR(pmx->sys2pci_base))
if (IS_ERR(pmx->sys2pci_base)) {
of_node_put(sys2pci_np);
return -ENOMEM;
}

pmx->dev = &pdev->dev;

Expand Down

0 comments on commit 151b8c5

Please sign in to comment.