Merge pull request #326 from adam3smith/nits2

test fixes exclusively
zotero · Apr 28, 2012 · 7b7bc19 · 7b7bc19
2 parents 7e50d06 + ba9adf1
commit 7b7bc19
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 67 deletions.
diff --git a/IMDb.js b/IMDb.js
@@ -8,8 +8,8 @@
 	"priority": 100,
 	"inRepository": true,
 	"translatorType": 4,
-	"browserSupport": "gcsv",
-	"lastUpdated": "2012-03-07 17:24:39"
+	"browserSupport": "gcs",
+	"lastUpdated": "2012-04-28 00:33:00"
 }
 
 /*
@@ -127,58 +127,72 @@ function addCreator(item, creator, type) {
 	return item;
 }
 /** BEGIN TEST CASES **/
-var testCases = [{
-	"type": "web",
-	"url": "http://www.imdb.com/title/tt0089276/",
-	"items": [{
-		"itemType": "film",
-		"creators": [{
-			"firstName": "Luis",
-			"lastName": "Puenzo",
-			"creatorType": "director"
-		}, {
-			"firstName": "Aída",
-			"lastName": "Bortnik",
-			"creatorType": "scriptwriter"
-		}, {
-			"firstName": "Luis",
-			"lastName": "Puenzo",
-			"creatorType": "scriptwriter"
-		}, {
-			"firstName": "Norma",
-			"lastName": "Aleandro",
-			"creatorType": "contributor"
-		}, {
-			"firstName": "Héctor",
-			"lastName": "Alterio",
-			"creatorType": "contributor"
-		}, {
-			"firstName": "Chunchuna",
-			"lastName": "Villafañe",
-			"creatorType": "contributor"
-		}, {
-			"firstName": "Hugo",
-			"lastName": "Arana",
-			"creatorType": "contributor"
-		}],
-		"notes": [],
-		"tags": [],
-		"seeAlso": [],
-		"attachments": [{
-			"url": "http://ia.media-imdb.com/images/M/MV5BMTMyNTc1MjIwNF5BMl5BanBnXkFtZTcwOTcyMTcyMQ@@._V1_SX320.jpg",
-			"title": "Poster"
-		}],
-		"title": "The Official Story",
-		"date": "8 Nov 1985",
-		"genre": "Drama, History, Thriller, War",
-		"abstractNote": "After the end of the Dirty War, a high school teacher sets out to find out who the mother of her adopted daughter is.",
-		"runningTime": "1 hr 52 mins",
-		"extra": "IMDB ID: tt0089276; IMDB Rating: 7.7 (3036 votes); Rotten Tomatoes: 8.3 (8 reviews  8 fresh, 0 rotten), Tomato Meter: 86",
-		"libraryCatalog": "IMDb"
-	}]
-}, {
-	"type": "web",
-	"url": "http://www.imdb.com/find?q=shakespeare&s=tt",
-	"items": "multiple"
-}]
-/** END TEST CASES **/
+var testCases = [
+	{
+		"type": "web",
+		"url": "http://www.imdb.com/title/tt0089276/",
+		"items": [
+			{
+				"itemType": "film",
+				"creators": [
+					{
+						"firstName": "Luis",
+						"lastName": "Puenzo",
+						"creatorType": "director"
+					},
+					{
+						"firstName": "Aída",
+						"lastName": "Bortnik",
+						"creatorType": "scriptwriter"
+					},
+					{
+						"firstName": "Luis",
+						"lastName": "Puenzo",
+						"creatorType": "scriptwriter"
+					},
+					{
+						"firstName": "Norma",
+						"lastName": "Aleandro",
+						"creatorType": "contributor"
+					},
+					{
+						"firstName": "Héctor",
+						"lastName": "Alterio",
+						"creatorType": "contributor"
+					},
+					{
+						"firstName": "Chunchuna",
+						"lastName": "Villafañe",
+						"creatorType": "contributor"
+					},
+					{
+						"firstName": "Hugo",
+						"lastName": "Arana",
+						"creatorType": "contributor"
+					}
+				],
+				"notes": [],
+				"tags": [],
+				"seeAlso": [],
+				"attachments": [
+					{
+						"title": "Poster"
+					}
+				],
+				"title": "The Official Story",
+				"date": "8 Nov 1985",
+				"genre": "Drama, History, Thriller, War",
+				"abstractNote": "After the end of the Dirty War, a high school teacher sets out to find out who the mother of her adopted daughter is.",
+				"runningTime": "1 hr 52 mins",
+				"extra": "IMDB ID: tt0089276; IMDB Rating: 7.7 (3036 votes); Rotten Tomatoes: N/A (N/A reviews  N/A fresh, N/A rotten), Tomato Meter: N/A",
+				"libraryCatalog": "IMDb"
+			}
+		]
+	},
+	{
+		"type": "web",
+		"url": "http://www.imdb.com/find?q=shakespeare&s=tt",
+		"items": "multiple"
+	}
+]
+/** END TEST CASES **/
diff --git a/Library Catalog (BiblioCommons).js b/Library Catalog (BiblioCommons).js
@@ -8,8 +8,8 @@
 	"priority": 100,
 	"inRepository": true,
 	"translatorType": 4,
-	"browserSupport": "gcsv",
-	"lastUpdated": "2012-04-27 13:06:22"
+	"browserSupport": "gcs",
+	"lastUpdated": "2012-04-28 00:35:01"
 }
 
 /*
@@ -180,12 +180,6 @@ var testCases = [
 			}
 		]
 	},
-	{
-		"type": "web",
-		"defer": true,
-		"url": "http://nypl.bibliocommons.com/search?t=smart&search_category=keyword&q=tatar&commit=Search&searchOpt=catalogue",
-		"items": "multiple"
-	},
 	{
 		"type": "web",
 		"url": "http://bostonpl.bibliocommons.com/item/show/3679347042_adam_smith",
@@ -215,7 +209,7 @@ var testCases = [
 				"numPages": "179",
 				"series": "Major conservative and libertarian thinkers",
 				"seriesNumber": "v. 16",
-				"callNumber": "HB103.S6",
+				"callNumber": "HB103.S6 O88 2011",
 				"libraryCatalog": "bostonpl Library Catalog"
 			}
 		]

diff --git a/SpringerLink.js b/SpringerLink.js
@@ -9,7 +9,7 @@
 	"inRepository": true,
 	"translatorType": 4,
 	"browserSupport": "gcs",
-	"lastUpdated": "2012-04-08 23:24:50"
+	"lastUpdated": "2012-04-28 00:47:08"
 }
 
 /*
@@ -423,6 +423,11 @@ var testCases = [
 						"firstName": "Maria",
 						"lastName": "Anisimova",
 						"creatorType": "editor"
+					},
+					{
+						"firstName": "John M.",
+						"lastName": "Walker",
+						"creatorType": "editor"
 					}
 				],
 				"notes": [],