Skip to content

Commit

Permalink
Bump min macOS version to 10.11 #trivial
Browse files Browse the repository at this point in the history
Summary:
Followup from Instagram#1068

The `NSIndexPath` methods we use **are not** available <10.11. In theory this has always been "broken" b/c older macOS versions would crash at runtime when trying to use these methods.

Normally this would be breaking change, but I can't imagine anyone is using IGListKit on the mac targeting 10.10 and shipping a working app.

cc jessesquires for thoughts

This should be the last remaining item before we get a green badge.

(note that 10.11 was released 9/30/15 which is about 2 weeks before the public IGListKit release)
Closes Instagram#1080

Differential Revision: D6894369

Pulled By: rnystrom

fbshipit-source-id: e5992c7bba68b21704af6bc8fb889b5427266954
  • Loading branch information
Ryan Nystrom authored and facebook-github-bot committed Feb 3, 2018
1 parent 95b779a commit 37c798a
Show file tree
Hide file tree
Showing 16 changed files with 926 additions and 926 deletions.
2 changes: 1 addition & 1 deletion Examples/Examples-iOS/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ EXTERNAL SOURCES:
:path: ../../IGListKit.podspec

SPEC CHECKSUMS:
IGListKit: ad72a9ea588e731218b90b9af62203f38c8f69d8
IGListKit: 13996c8df98fed98a5076845aabc22cdc7732aee

PODFILE CHECKSUM: 0d505f6895c1f8c0016d78680f9b532c444cbb5e

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Examples/Examples-iOS/Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

488 changes: 244 additions & 244 deletions Examples/Examples-iOS/Pods/Pods.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Examples/Examples-macOS/Podfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use_frameworks!
platform :osx, '10.10'
platform :osx, '10.11'

target 'IGListKitExamples' do
pod 'IGListKit', :path => '../../IGListKit.podspec'
Expand Down
4 changes: 2 additions & 2 deletions Examples/Examples-macOS/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ EXTERNAL SOURCES:
:path: ../../IGListKit.podspec

SPEC CHECKSUMS:
IGListKit: ad72a9ea588e731218b90b9af62203f38c8f69d8
IGListKit: 13996c8df98fed98a5076845aabc22cdc7732aee

PODFILE CHECKSUM: bbe5708b3a7f2dd7c70bb14225a7e37f67e1de58
PODFILE CHECKSUM: b2d4196e45c2a81ef18daa376d33978bf335df7c

COCOAPODS: 1.4.0

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Examples/Examples-macOS/Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

764 changes: 382 additions & 382 deletions Examples/Examples-macOS/Pods/Pods.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Examples/Examples-tvOS/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ EXTERNAL SOURCES:
:path: ../../IGListKit.podspec

SPEC CHECKSUMS:
IGListKit: ad72a9ea588e731218b90b9af62203f38c8f69d8
IGListKit: 13996c8df98fed98a5076845aabc22cdc7732aee

PODFILE CHECKSUM: f68cec0d93efa38d42ede50dfe01309d83664d56

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Examples/Examples-tvOS/Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

488 changes: 244 additions & 244 deletions Examples/Examples-tvOS/Pods/Pods.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion IGListKit.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Pod::Spec.new do |s|

s.ios.deployment_target = '8.0'
s.tvos.deployment_target = '9.0'
s.osx.deployment_target = '10.10'
s.osx.deployment_target = '10.11'

s.ios.frameworks = 'UIKit'
s.tvos.frameworks = 'UIKit'
Expand Down
4 changes: 2 additions & 2 deletions IGListKit.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -2198,7 +2198,7 @@
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.10;
MACOSX_DEPLOYMENT_TARGET = 10.11;
OTHER_CFLAGS = (
"-Wambiguous-macro",
"-Wbool-conversion",
Expand Down Expand Up @@ -2274,7 +2274,7 @@
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.10;
MACOSX_DEPLOYMENT_TARGET = 10.11;
OTHER_CFLAGS = (
"-Wambiguous-macro",
"-Wbool-conversion",
Expand Down
82 changes: 41 additions & 41 deletions Pods/Pods.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

0 comments on commit 37c798a

Please sign in to comment.