Reorder calls to fix ice candidate not set when ice starts to trickle (…

…ionorg#354)
zshaobo · Jan 2, 2021 · ff430d3 · ff430d3
1 parent 5625391
commit ff430d3
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/cmd/signal/json-rpc/server/server.go b/cmd/signal/json-rpc/server/server.go
@@ -55,12 +55,6 @@ func (p *JSONSignal) Handle(ctx context.Context, conn *jsonrpc2.Conn, req *jsonr
 			break
 		}
 
-		answer, err := p.Join(join.Sid, join.Offer)
-		if err != nil {
-			replyError(err)
-			break
-		}
-
 		p.OnOffer = func(offer *webrtc.SessionDescription) {
 			if err := conn.Notify(ctx, "offer", offer); err != nil {
 				log.Errorf("error sending offer %s", err)
@@ -76,6 +70,12 @@ func (p *JSONSignal) Handle(ctx context.Context, conn *jsonrpc2.Conn, req *jsonr
 			}
 		}
 
+		answer, err := p.Join(join.Sid, join.Offer)
+		if err != nil {
+			replyError(err)
+			break
+		}
+
 		_ = conn.Reply(ctx, req.ID, answer)
 
 	case "offer":