Skip to content

Commit

Permalink
Activity Timeout Engine changes.
Browse files Browse the repository at this point in the history
Reviewers: maxim, tamer, samar

Reviewed By: samar

Subscribers: jenkins

Differential Revision: https://code.uberinternal.com/D698711
  • Loading branch information
sivakku committed Jan 23, 2017
1 parent 1f7f0f3 commit 2700912
Show file tree
Hide file tree
Showing 27 changed files with 1,539 additions and 85 deletions.
46 changes: 45 additions & 1 deletion .gen/go/shared/ttypes.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions .gen/js/shared_types.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 15 additions & 3 deletions .gen/py/shared/ttypes.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions client/history/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,13 @@ func (c *clientImpl) RespondActivityTaskFailed(request *workflow.RespondActivity
defer cancel()
return client.RespondActivityTaskFailed(ctx, request)
}

func (c *clientImpl) RecordActivityTaskHeartbeat(request *workflow.RecordActivityTaskHeartbeatRequest) (*workflow.RecordActivityTaskHeartbeatResponse, error) {
client, err := c.getHostForRequest(shardID)
if err != nil {
return nil, err
}
ctx, cancel := c.createContext()
defer cancel()
return client.RecordActivityTaskHeartbeat(ctx, request)
}
1 change: 1 addition & 0 deletions client/history/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ type Client interface {
RespondDecisionTaskCompleted(request *workflow.RespondDecisionTaskCompletedRequest) error
RespondActivityTaskCompleted(request *workflow.RespondActivityTaskCompletedRequest) error
RespondActivityTaskFailed(request *workflow.RespondActivityTaskFailedRequest) error
RecordActivityTaskHeartbeat(request *workflow.RecordActivityTaskHeartbeatRequest) (*workflow.RecordActivityTaskHeartbeatResponse, error)
}
3 changes: 3 additions & 0 deletions common/metrics/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ const (
RespondActivityTaskFailedScope
GetWorkflowExecutionHistoryScope
GetTimerIndexTasksScope
GetWorkflowMutableStateScope
)

// ScopeToTags record the scope name for all services
Expand All @@ -111,6 +112,7 @@ var ScopeToTags = [NumServices][]map[string]string{
{OperationTagName: RespondActivityTaskFailedOperationTagValue},
{OperationTagName: GetWorkflowExecutionHistoryOperationTagValue},
{OperationTagName: GetTimerIndexTasksOperationTagValue},
{OperationTagName: GetWorkflowMutableStateOperationTagValue},
},
}

Expand Down Expand Up @@ -169,6 +171,7 @@ const (
RespondActivityTaskFailedOperationTagValue = "RespondActivityTaskFailed"
GetWorkflowExecutionHistoryOperationTagValue = "GetWorkflowExecutionHistory"
GetTimerIndexTasksOperationTagValue = "GetTimerIndexTasks"
GetWorkflowMutableStateOperationTagValue = "GetWorkflowMutableState"
)

// ErrorClass is an enum to help with classifying SLA vs. non-SLA errors (SLA = "service level agreement")
Expand Down
Loading

0 comments on commit 2700912

Please sign in to comment.