Mockery deprecation (cadence-workflow#2724)

* Use goimports instead of gofmt for better imports management
* Deprecate domain cache mockery

Makefile

@@ -140,7 +140,27 @@ go-generate:
 	@echo "running go generate ./..."
 	@go generate ./...
 
-bins_nothrift: go-generate lint copyright cadence-cassandra-tool cadence-sql-tool cadence cadence-server
+lint:
+	@echo "running linter"
+	@lintFail=0; for file in $(ALL_SRC); do \
+		golint "$$file"; \
+		if [ $$? -eq 1 ]; then lintFail=1; fi; \
+	done; \
+	if [ $$lintFail -eq 1 ]; then exit 1; fi;
+	@OUTPUT=`gofmt -l $(ALL_SRC) 2>&1`; \
+	if [ "$$OUTPUT" ]; then \
+		echo "Run 'make fmt'. gofmt must be run on the following files:"; \
+		echo "$$OUTPUT"; \
+		exit 1; \
+	fi
+
+fmt:
+	GO111MODULE=off go get -u github.com/myitcv/gobin
+	GOOS= GOARCH= gobin -mod=readonly golang.org/x/tools/cmd/goimports
+	@echo "running goimports"
+	@goimports -w $(ALL_SRC)
+
+bins_nothrift: go-generate fmt lint copyright cadence-cassandra-tool cadence-sql-tool cadence cadence-server
 
 bins: thriftc bins_nothrift
 
@@ -215,23 +235,6 @@ cover: $(COVER_ROOT)/cover.out
 cover_ci: $(COVER_ROOT)/cover.out
 	goveralls -coverprofile=$(COVER_ROOT)/cover.out -service=buildkite || echo Coveralls failed;
 
-lint:
-	@echo Running linter
-	@lintFail=0; for file in $(ALL_SRC); do \
-		golint "$$file"; \
-		if [ $$? -eq 1 ]; then lintFail=1; fi; \
-	done; \
-	if [ $$lintFail -eq 1 ]; then exit 1; fi;
-	@OUTPUT=`gofmt -l $(ALL_SRC) 2>&1`; \
-	if [ "$$OUTPUT" ]; then \
-		echo "Run 'make fmt'. gofmt must be run on the following files:"; \
-		echo "$$OUTPUT"; \
-		exit 1; \
-	fi
-
-fmt:
-	@gofmt -w $(ALL_SRC)
-
 clean:
 	rm -f cadence
 	rm -f cadence-sql-tool

client/admin/metricClient.go

@@ -22,6 +22,7 @@ package admin
 
 import (
 	"context"
+
 	"github.com/uber/cadence/.gen/go/admin"
 	"github.com/uber/cadence/.gen/go/shared"
 	"github.com/uber/cadence/common/metrics"

client/history/retryableClient.go

@@ -22,6 +22,7 @@ package history
 
 import (
 	"context"
+
 	h "github.com/uber/cadence/.gen/go/history"
 	"github.com/uber/cadence/.gen/go/replicator"
 	"github.com/uber/cadence/.gen/go/shared"

cmd/server/tools.go

@@ -28,6 +28,8 @@ import (
 	// yarpc plugin for thriftrw code gen
 	_ "go.uber.org/yarpc/encoding/thrift/thriftrw-plugin-yarpc"
 
+	// goimports
+	_ "golang.org/x/tools/cmd/goimports"
 	// mockgen for generating mocks
 	_ "github.com/golang/mock/mockgen"
 )

cmd/tools/cassandra/main.go

@@ -21,8 +21,9 @@
 package main
 
 import (
-	"github.com/uber/cadence/tools/cassandra"
 	"os"
+
+	"github.com/uber/cadence/tools/cassandra"
 )
 
 func main() {

cmd/tools/sql/main.go

@@ -21,8 +21,9 @@
 package main
 
 import (
-	"github.com/uber/cadence/tools/sql"
 	"os"
+
+	"github.com/uber/cadence/tools/sql"
 )
 
 func main() {

common/cache/domainCache.go

@@ -18,6 +18,8 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
+//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination domainCache_mock.go -self_package github.com/uber/cadence/common/cache
+
 package cache
 
 import (