Skip to content

Commit

Permalink
Fixed task loss due to rangeID update while retrying task add. Fixed …
Browse files Browse the repository at this point in the history
…range stealing

Summary: Fixed task loss due to rangeID update while retrying task add. Fixed range stealing

Reviewers: samar, sivakk, tamer

Reviewed By: sivakk, tamer

Subscribers: jenkins, aravindv, venkat

Differential Revision: https://code.uberinternal.com/D737304
  • Loading branch information
Maxim Fateev committed Feb 15, 2017
1 parent a8efd14 commit 5be6382
Show file tree
Hide file tree
Showing 6 changed files with 624 additions and 104 deletions.
2 changes: 2 additions & 0 deletions common/persistence/cassandraPersistence.go
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,8 @@ func (d *cassandraPersistence) UpdateTaskList(request *UpdateTaskListRequest) (*
tli.AckLevel,
&tli.Name,
tli.TaskType,
rowTypeTaskList,
taskListTaskID,
tli.RangeID,
)

Expand Down
35 changes: 21 additions & 14 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ import:
- hashring
- package: github.com/dgryski/go-farm
- package: github.com/emirpasic/gods
- package: github.com/davecgh/go-spew
6 changes: 4 additions & 2 deletions service/matching/loggingHelpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ const (
tagValueActionTimerFired = "add-timer-fired-event"

// tagStoreOperation values
tagValueStoreOperationGetTasks = "get-tasks"
tagValueStoreOperationCompleteTask = "complete-task"
tagValueStoreOperationGetTasks = "get-tasks"
tagValueStoreOperationCompleteTask = "complete-task"
tagValueStoreOperationUpdateTaskList = "update-task-list"

tagValueStoreOperationCreateWorkflowExecution = "create-wf-execution"
tagValueStoreOperationGetWorkflowExecution = "get-wf-execution"
tagValueStoreOperationGetWorkflowMutableState = "get-wf-mutable-state"
Expand Down
Loading

0 comments on commit 5be6382

Please sign in to comment.