Add domain tag on workflow handler metrics (cadence-workflow#1648)

* Move workflow handler metrics to new style metrics emission
* Add domain tag to scope once we have it available. Ensure timers are additionally emitted with domain tag `all`
* Method to create a noop scope for tests

common/metrics/scope.go

@@ -35,6 +35,11 @@ func newMetricsScope(scope tally.Scope, defs map[int]metricDefinition) Scope {
 	return &metricsScope{scope, defs}
 }
 
+// NoopScope returns a noop scope of metrics
+func NoopScope(serviceIdx ServiceIdx) Scope {
+	return &metricsScope{tally.NoopScope, getMetricDefs(serviceIdx)}
+}
+
 func (m *metricsScope) IncCounter(id int) {
 	name := string(m.defs[id].metricName)
 	m.scope.Counter(name).Inc(1)

common/util.go

@@ -381,14 +381,8 @@ func CreateHistoryStartWorkflowRequest(domainID string, startRequest *workflow.S
 
 // CheckEventBlobSizeLimit checks if a blob data exceeds limits. It logs a warning if it exceeds warnLimit,
 // and return ErrBlobSizeExceedsLimit if it exceeds errorLimit.
-func CheckEventBlobSizeLimit(actualSize, warnLimit, errorLimit int, domainID, workflowID, runID string, metricsClient metrics.Client, scope int, logger bark.Logger) error {
-	if metricsClient != nil {
-		metricsClient.RecordTimer(
-			scope,
-			metrics.EventBlobSize,
-			time.Duration(actualSize),
-		)
-	}
+func CheckEventBlobSizeLimit(actualSize, warnLimit, errorLimit int, domainID, workflowID, runID string, scope metrics.Scope, logger bark.Logger) error {
+	scope.RecordTimer(metrics.EventBlobSize, time.Duration(actualSize))
 
 	if actualSize > warnLimit {
 		if logger != nil {