Skip to content

Commit

Permalink
bugfix dynamic config (cadence-workflow#596)
Browse files Browse the repository at this point in the history
  • Loading branch information
wxing1292 authored Mar 6, 2018
1 parent 5782955 commit d17af66
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cmd/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"github.com/uber/cadence/common/cluster"
"github.com/uber/cadence/common/service"
"github.com/uber/cadence/common/service/config"
"github.com/uber/cadence/common/service/dynamicconfig"
"github.com/uber/cadence/service/frontend"
"github.com/uber/cadence/service/history"
"github.com/uber/cadence/service/matching"
Expand Down Expand Up @@ -118,6 +119,7 @@ func (s *server) startService() common.Daemon {
)
// TODO: We need to switch Cadence to use zap logger, until then just pass zap.NewNop
params.MessagingClient = s.cfg.Kafka.NewKafkaClient(zap.NewNop(), params.Logger, params.MetricScope)
params.DynamicConfig = dynamicconfig.NewNopClient()

var daemon common.Daemon

Expand Down

0 comments on commit d17af66

Please sign in to comment.