Skip to content

Commit

Permalink
Remove unneeded StringPiece header usage
Browse files Browse the repository at this point in the history
Bug: 40506050
Change-Id: I15636e78efea9243ad7c13c9e91e82d683f70a35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688848
Owners-Override: Lei Zhang <[email protected]>
Auto-Submit: Helmut Januschka <[email protected]>
Commit-Queue: Helmut Januschka <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1326238}
  • Loading branch information
hjanuschka authored and Chromium LUCI CQ committed Jul 11, 2024
1 parent 53cec00 commit 5452f21
Show file tree
Hide file tree
Showing 83 changed files with 1 addition and 84 deletions.
1 change: 0 additions & 1 deletion base/files/scoped_file_linux.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "base/debug/stack_trace.h"
#include "base/immediate_crash.h"
#include "base/logging.h"
#include "base/strings/string_piece.h"

namespace {

Expand Down
1 change: 0 additions & 1 deletion base/fuchsia/fidl_event_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "base/fuchsia/fuchsia_logging.h"
#include "base/functional/callback.h"
#include "base/location.h"
#include "base/strings/string_piece.h"

namespace fidl {
template <typename Protocol>
Expand Down
1 change: 0 additions & 1 deletion base/fuchsia/scheduler.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef BASE_FUCHSIA_SCHEDULER_H_
#define BASE_FUCHSIA_SCHEDULER_H_

#include "base/strings/string_piece.h"
#include "base/time/time.h"

namespace base {
Expand Down
1 change: 0 additions & 1 deletion base/fuchsia/scoped_natural_service_binding_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "base/fuchsia/test_component_context_for_process.h"
#include "base/fuchsia/test_interface_natural_impl.h"
#include "base/run_loop.h"
#include "base/strings/string_piece.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
Expand Down
1 change: 0 additions & 1 deletion base/fuchsia/scoped_service_binding_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "base/fuchsia/test_component_context_for_process.h"
#include "base/fuchsia/test_interface_impl.h"
#include "base/run_loop.h"
#include "base/strings/string_piece.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
Expand Down
1 change: 0 additions & 1 deletion base/i18n/icu_string_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include "base/check_op.h"
#include "base/format_macros.h"
#include "base/strings/string_piece.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
Expand Down
1 change: 0 additions & 1 deletion base/i18n/message_formatter_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include "base/i18n/rtl.h"
#include "base/i18n/unicodestring.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
Expand Down
1 change: 0 additions & 1 deletion base/ios/scoped_critical_action_unittest.mm
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <memory>

#include "base/strings/string_piece.h"
#include "base/test/task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
Expand Down
1 change: 0 additions & 1 deletion base/process/set_process_title_linux_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/process/set_process_title_linux.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
Expand Down
1 change: 0 additions & 1 deletion base/strings/abseil_string_number_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include <limits>

#include "base/strings/string_piece.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/abseil-cpp/absl/numeric/int128.h"

Expand Down
2 changes: 1 addition & 1 deletion base/strings/string_split.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ bool AppendStringKeyValue(std::string_view input,
std::string_view remains =
input.substr(end_key_pos, input.size() - end_key_pos);
size_t begin_value_pos = remains.find_first_not_of(delimiter);
if (begin_value_pos == StringPiece::npos) {
if (begin_value_pos == std::string_view::npos) {
DVLOG(1) << "cannot parse value from input: " << input;
return false; // No value.
}
Expand Down
1 change: 0 additions & 1 deletion base/strings/string_util_posix.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include <wchar.h>

#include "base/check.h"
#include "base/strings/string_piece.h"

namespace base {

Expand Down
1 change: 0 additions & 1 deletion base/strings/sys_string_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <string>

#include "base/strings/string_piece.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_locale.h"
Expand Down
1 change: 0 additions & 1 deletion base/strings/utf_offset_string_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

#include <algorithm>

#include "base/strings/string_piece.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace base {
Expand Down
1 change: 0 additions & 1 deletion base/strings/utf_string_conversion_utils_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <string>

#include "base/strings/string_piece.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace base {
Expand Down
1 change: 0 additions & 1 deletion base/strings/utf_string_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <stddef.h>

#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
Expand Down
1 change: 0 additions & 1 deletion base/system/sys_info_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/system/sys_info_internal.h"
Expand Down
1 change: 0 additions & 1 deletion base/system/sys_info_chromeos.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "base/no_destructor.h"
#include "base/notreached.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/strings/string_tokenizer.h"
#include "base/strings/string_util.h"
Expand Down
1 change: 0 additions & 1 deletion base/system/sys_info_fuchsia.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "base/no_destructor.h"
#include "base/notimplemented.h"
#include "base/numerics/clamped_math.h"
#include "base/strings/string_piece.h"
#include "base/synchronization/lock.h"
#include "base/threading/scoped_blocking_call.h"
#include "build/build_config.h"
Expand Down
1 change: 0 additions & 1 deletion base/task/thread_pool/task_tracker.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "base/containers/circular_deque.h"
#include "base/functional/callback_forward.h"
#include "base/sequence_checker.h"
#include "base/strings/string_piece.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/common/checked_lock.h"
#include "base/task/common/task_annotator.h"
Expand Down
1 change: 0 additions & 1 deletion base/threading/scoped_blocking_call.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include "base/base_export.h"
#include "base/functional/callback_forward.h"
#include "base/location.h"
#include "base/strings/string_piece.h"
#include "base/threading/scoped_blocking_call_internal.h"
#include "base/types/strong_alias.h"

Expand Down
1 change: 0 additions & 1 deletion base/time/time_win_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include <limits>
#include <vector>

#include "base/strings/string_piece.h"
#include "base/threading/platform_thread.h"
#include "base/win/registry.h"
#include "build/build_config.h"
Expand Down
1 change: 0 additions & 1 deletion components/about_ui/credit_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <stdint.h>

#include "base/strings/string_piece.h"
#include "build/chromeos_buildflags.h"
#include "components/grit/components_resources.h"
#include "ui/base/resource/resource_bundle.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "base/debug/allocation_trace.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string_piece.h"
#include "base/types/expected.h"

namespace crashpad {
Expand Down
1 change: 0 additions & 1 deletion components/cast/message_port/blink_message_port_adapter.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <memory>
#include <vector>

#include "base/strings/string_piece.h"
#include "components/cast/message_port/message_port.h"
#include "third_party/blink/public/common/messaging/web_message_port.h"

Expand Down
1 change: 0 additions & 1 deletion components/certificate_transparency/ct_known_logs.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include "base/component_export.h"
#include "base/memory/raw_ptr_exclusion.h"
#include "base/strings/string_piece.h"
#include "base/time/time.h"
#include "build/build_config.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "base/path_service.h"
#include "base/rand_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/strings/stringprintf.h"
#include "base/task/single_thread_task_runner.h"
Expand Down
1 change: 0 additions & 1 deletion components/cloud_devices/common/printer_description.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "base/json/json_writer.h"
#include "base/notreached.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/values.h"
#include "build/build_config.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "components/content_settings/core/common/content_settings_pattern_parser.h"
#include "components/content_settings/core/common/content_settings_pattern.h"

#include "base/strings/string_piece.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion components/cronet/url_request_context_config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/task/sequenced_task_runner.h"
#include "base/values.h"
Expand Down
2 changes: 0 additions & 2 deletions components/dom_distiller/core/url_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

#include <string>

#include "base/strings/string_piece.h"

class GURL;

namespace dom_distiller {
Expand Down
1 change: 0 additions & 1 deletion components/download/internal/common/download_item_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
#include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h"
#include "base/observer_list.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/test/scoped_feature_list.h"
#include "components/embedder_support/origin_trials/features.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "base/no_destructor.h"
#include "base/run_loop.h"
#include "base/sequence_checker.h"
#include "base/strings/string_piece.h"
#include "base/system/sys_info.h"
#include "base/task/single_thread_task_runner.h"
#include "components/policy/core/common/cloud/dm_token.h"
Expand Down
1 change: 0 additions & 1 deletion components/exo/shell_surface.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "base/debug/crash_logging.h"
#include "base/functional/bind.h"
#include "base/logging.h"
#include "base/strings/string_piece.h"
#include "base/strings/utf_string_conversions.h"
#include "base/trace_event/trace_event.h"
#include "cc/layers/deadline_policy.h"
Expand Down
1 change: 0 additions & 1 deletion components/feed/core/v2/stream/info_card_tracker.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <vector>

#include "base/memory/raw_ptr.h"
#include "base/strings/string_piece.h"
#include "base/time/time.h"
#include "components/feed/core/proto/v2/wire/info_card.pb.h"
#include "components/feed/core/v2/public/common_enums.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include <iosfwd>

#include "base/strings/string_piece.h"
#include "base/time/time.h"
#include "components/feed/core/proto/v2/store.pb.h"
#include "components/feed/core/v2/enums.h"
Expand Down
1 change: 0 additions & 1 deletion components/feedback/redaction_tool/url_canon_stdstring.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include "base/compiler_specific.h"
#include "base/memory/raw_ptr_exclusion.h"
#include "base/strings/string_piece.h"
#include "components/feedback/redaction_tool/url_canon.h"

namespace redaction_internal {
Expand Down
1 change: 0 additions & 1 deletion components/gcm_driver/crypto/encryption_header_parsers.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>
#include <string>

#include "base/strings/string_piece.h"
#include "net/http/http_util.h"

namespace gcm {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "base/functional/callback_helpers.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/task_environment.h"
Expand Down
1 change: 0 additions & 1 deletion components/history_clusters/core/config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/no_destructor.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "build/build_config.h"
#include "components/history_clusters/core/features.h"
Expand Down
1 change: 0 additions & 1 deletion components/history_clusters/core/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "base/containers/contains.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "build/build_config.h"
#include "ui/base/l10n/l10n_util.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <string>

#include "base/memory/raw_ptr.h"
#include "base/strings/string_piece.h"

class PrefService;

Expand Down
1 change: 0 additions & 1 deletion components/live_caption/live_translate_controller.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "base/json/json_reader.h"
#include "base/metrics/histogram_functions.h"
#include "base/metrics/metrics_hashes.h"
#include "base/strings/string_piece.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
#include "components/live_caption/pref_names.h"
Expand Down
1 change: 0 additions & 1 deletion components/media_router/browser/test/test_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <string>
#include <vector>

#include "base/strings/string_piece.h"
#include "base/test/values_test_util.h"
#include "components/media_router/browser/media_routes_observer.h"
#include "components/media_router/browser/media_sinks_observer.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include "base/fuchsia/fuchsia_logging.h"
#include "base/fuchsia/process_context.h"
#include "base/strings/string_piece.h"
#include "base/time/time.h"
#include "components/memory_pressure/memory_pressure_voter.h"

Expand Down
1 change: 0 additions & 1 deletion components/metrics/expired_histograms_checker.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "base/containers/span.h"
#include "base/memory/raw_span.h"
#include "base/metrics/record_histogram_checker.h"
#include "base/strings/string_piece.h"

namespace metrics {

Expand Down
1 change: 0 additions & 1 deletion components/ntp_tiles/icon_cacher_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include "base/functional/bind.h"
#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_piece.h"
#include "components/favicon/core/favicon_service.h"
#include "components/favicon/core/favicon_util.h"
#include "components/favicon/core/large_icon_service.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include "base/metrics/field_trial.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
Expand Down
Loading

0 comments on commit 5452f21

Please sign in to comment.