Skip to content

Commit

Permalink
device-dax: fail all private mapping attempts
Browse files Browse the repository at this point in the history
The device-dax implementation originally tried to be tricky and allow
private read-only mappings, but in the process allowed writable
MAP_PRIVATE + MAP_NORESERVE mappings.  For simplicity and predictability
just fail all private mapping attempts since device-dax memory is
statically allocated and will never support overcommit.

Cc: <[email protected]>
Cc: Dave Hansen <[email protected]>
Fixes: dee4107 ("/dev/dax, core: file operations and dax-mmap")
Reported-by: Pawel Lebioda <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
  • Loading branch information
djbw committed Nov 16, 2016
1 parent 6a84fb4 commit 4cb1935
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/dax/dax.c
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ static int check_vma(struct dax_dev *dax_dev, struct vm_area_struct *vma,
if (!dax_dev->alive)
return -ENXIO;

/* prevent private / writable mappings from being established */
if ((vma->vm_flags & (VM_NORESERVE|VM_SHARED|VM_WRITE)) == VM_WRITE) {
/* prevent private mappings from being established */
if ((vma->vm_flags & VM_SHARED) != VM_SHARED) {
dev_info(dev, "%s: %s: fail, attempted private mapping\n",
current->comm, func);
return -EINVAL;
Expand Down

0 comments on commit 4cb1935

Please sign in to comment.