Skip to content

Commit

Permalink
[media] firewire: use dev_dbg() instead of printk()
Browse files Browse the repository at this point in the history
A structure for firedtv (struct firedtv) has a member for a pointer to
struct device. In this case, we can use dev_dbg() for debug printing.
This is more preferrable behaviour in device driver development.

Signed-off-by: Takashi Sakamoto <[email protected]>
Acked-by: Stefan Richter <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
takaswie authored and mchehab committed Oct 21, 2016
1 parent 2a3edc5 commit f96cffd
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/media/firewire/firedtv-rc.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code)
else if (code >= 0x4540 && code <= 0x4542)
code = oldtable[code - 0x4521];
else {
printk(KERN_DEBUG "firedtv: invalid key code 0x%04x "
"from remote control\n", code);
dev_dbg(fdtv->device,
"invalid key code 0x%04x from remote control\n",
code);
return;
}

Expand Down

0 comments on commit f96cffd

Please sign in to comment.