Skip to content

Commit

Permalink
selftests/powerpc: Add TM signal return test
Browse files Browse the repository at this point in the history
Test the kernel's signal return code to ensure that it doesn't crash
when both the transactional and suspend MSR bits are set in the signal
context.

Signed-off-by: Michael Neuling <[email protected]>
Tested-by: Anshuman Khandual <[email protected]>
[mpe: Skip if we don't have TM]
Signed-off-by: Michael Ellerman <[email protected]>
  • Loading branch information
mikey authored and mpe committed Dec 14, 2015
1 parent b319ee8 commit 25007a6
Show file tree
Hide file tree
Showing 3 changed files with 76 additions and 1 deletion.
1 change: 1 addition & 0 deletions tools/testing/selftests/powerpc/tm/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
tm-resched-dscr
tm-syscall
tm-signal-msr-resv
2 changes: 1 addition & 1 deletion tools/testing/selftests/powerpc/tm/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
TEST_PROGS := tm-resched-dscr tm-syscall
TEST_PROGS := tm-resched-dscr tm-syscall tm-signal-msr-resv

all: $(TEST_PROGS)

Expand Down
74 changes: 74 additions & 0 deletions tools/testing/selftests/powerpc/tm/tm-signal-msr-resv.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
* Copyright 2015, Michael Neuling, IBM Corp.
* Licensed under GPLv2.
*
* Test the kernel's signal return code to ensure that it doesn't
* crash when both the transactional and suspend MSR bits are set in
* the signal context.
*
* For this test, we send ourselves a SIGUSR1. In the SIGUSR1 handler
* we modify the signal context to set both MSR TM S and T bits (which
* is "reserved" by the PowerISA). When we return from the signal
* handler (implicit sigreturn), the kernel should detect reserved MSR
* value and send us with a SIGSEGV.
*/

#include <stdlib.h>
#include <stdio.h>
#include <signal.h>
#include <unistd.h>

#include "utils.h"
#include "tm.h"

int segv_expected = 0;

void signal_segv(int signum)
{
if (segv_expected && (signum == SIGSEGV))
_exit(0);
_exit(1);
}

void signal_usr1(int signum, siginfo_t *info, void *uc)
{
ucontext_t *ucp = uc;

/* Link tm checkpointed context to normal context */
ucp->uc_link = ucp;
/* Set all TM bits so that the context is now invalid */
#ifdef __powerpc64__
ucp->uc_mcontext.gp_regs[PT_MSR] |= (7ULL << 32);
#else
ucp->uc_mcontext.regs->gpr[PT_MSR] |= (7ULL);
#endif
/* Should segv on return becuase of invalid context */
segv_expected = 1;
}

int tm_signal_msr_resv()
{
struct sigaction act;

SKIP_IF(!have_htm());

act.sa_sigaction = signal_usr1;
sigemptyset(&act.sa_mask);
act.sa_flags = SA_SIGINFO;
if (sigaction(SIGUSR1, &act, NULL) < 0) {
perror("sigaction sigusr1");
exit(1);
}
if (signal(SIGSEGV, signal_segv) == SIG_ERR)
exit(1);

raise(SIGUSR1);

/* We shouldn't get here as we exit in the segv handler */
return 1;
}

int main(void)
{
return test_harness(tm_signal_msr_resv, "tm_signal_msr_resv");
}

0 comments on commit 25007a6

Please sign in to comment.