Skip to content

Commit

Permalink
ACPICA: Cleanup indentation to reduce differences between Linux and A…
Browse files Browse the repository at this point in the history
…CPICA.

This is a cosmetic patch only. Comparison of the resulting binary showed
only line number differences.

This patch does not affect the generation of the Linux binary.
This patch decreases 210 lines of 20121018 divergence.diff.

The ACPICA source codes uses a totally different indentation style from the
Linux to be compatible with other users (operating systems or BIOS).

Indentation differences are critical to the release automation. There are
two causes related to the "indentation" that are affecting the release
automation:
1. The ACPICA -> Linux release process is:
     ACPICA source -- acpisrc - hierarchy - indent ->
     linuxized ACPICA source -- diff ->
     linuxized ACPICA patch (x) -- human intervention ->
     linuxized ACPICA patch (o)
     Where
       'x' means "cannot be directly applied to the Linux"
       'o' means "can be directly applied to the Linux"
   Different "indent" version or "indent" options used in the "indent"
   step will lead to different divergences.
   The version of "indent" used for the current release process is:
     GNU indent 2.2.11
   The options of "indent" used for the current release process is:
     -npro -kr -i8 -ts8 -sob -l80 -ss -ncs
2. Manual indentation prettifying work in the Linux side will also harm the
   automatically generated linuxized ACPICA patches, making them impossible
   to apply directly.

This patch fixes source code differences caused by the two causes so that
the "human intervention" can be reduced in the future.

Signed-off-by: Lv Zheng <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
  • Loading branch information
Lv Zheng authored and rafaeljw committed Jan 10, 2013
1 parent 739dcbb commit 3e8214e
Show file tree
Hide file tree
Showing 28 changed files with 64 additions and 58 deletions.
1 change: 1 addition & 0 deletions drivers/acpi/acpica/aclocal.h
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@ struct acpi_opcode_info {
};

/* Value associated with the parse object */

union acpi_parse_value {
u64 integer; /* Integer constant (Up to 64 bits) */
u32 size; /* bytelist or field size */
Expand Down
13 changes: 7 additions & 6 deletions drivers/acpi/acpica/evxface.c
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ acpi_remove_notify_handler(acpi_handle device,
(handler_type > ACPI_MAX_NOTIFY_HANDLER_TYPE)) {
return_ACPI_STATUS(AE_BAD_PARAMETER);
}

/* Make sure all deferred notify tasks are completed */

acpi_os_wait_events_complete();
Expand Down Expand Up @@ -622,12 +623,12 @@ acpi_install_gpe_handler(acpi_handle gpe_device,
goto free_and_exit;
}


handler->address = address;
handler->context = context;
handler->method_node = gpe_event_info->dispatch.method_node;
handler->original_flags = gpe_event_info->flags &
(ACPI_GPE_XRUPT_TYPE_MASK | ACPI_GPE_DISPATCH_MASK);
handler->original_flags = (u8)(gpe_event_info->flags &
(ACPI_GPE_XRUPT_TYPE_MASK |
ACPI_GPE_DISPATCH_MASK));

/*
* If the GPE is associated with a method, it may have been enabled
Expand Down Expand Up @@ -746,10 +747,10 @@ acpi_remove_gpe_handler(acpi_handle gpe_device,
* enabled, it should be enabled at this point to restore the
* post-initialization configuration.
*/

if ((handler->original_flags & ACPI_GPE_DISPATCH_METHOD)
&& handler->originally_enabled)
if ((handler->original_flags & ACPI_GPE_DISPATCH_METHOD) &&
handler->originally_enabled) {
(void)acpi_ev_add_gpe_reference(gpe_event_info);
}

/* Now we can free the handler object */

Expand Down
1 change: 0 additions & 1 deletion drivers/acpi/acpica/evxfevnt.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ ACPI_MODULE_NAME("evxfevnt")
* DESCRIPTION: Transfers the system into ACPI mode.
*
******************************************************************************/

acpi_status acpi_enable(void)
{
acpi_status status;
Expand Down
1 change: 1 addition & 0 deletions drivers/acpi/acpica/evxfgpe.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ acpi_status acpi_disable_gpe(acpi_handle gpe_device, u32 gpe_number)
acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
return_ACPI_STATUS(status);
}

ACPI_EXPORT_SYMBOL(acpi_disable_gpe)


Expand Down
1 change: 0 additions & 1 deletion drivers/acpi/acpica/exconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ acpi_ex_add_table(u32 table_index,
* responsible for discovering any new wake GPEs by running _PRW methods
* that may have been loaded by this table.
*/

status = acpi_tb_get_owner_id(table_index, &owner_id);
if (ACPI_SUCCESS(status)) {
acpi_ev_update_gpes(owner_id);
Expand Down
1 change: 1 addition & 0 deletions drivers/acpi/acpica/exmutex.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ acpi_ex_release_mutex(union acpi_operand_object *obj_desc,
}

/* Must have a valid thread ID */

if (!walk_state->thread) {
ACPI_ERROR((AE_INFO,
"Cannot release Mutex [%4.4s], null thread info",
Expand Down
8 changes: 1 addition & 7 deletions drivers/acpi/acpica/exoparg1.c
Original file line number Diff line number Diff line change
Expand Up @@ -948,13 +948,7 @@ acpi_status acpi_ex_opcode_1A_0T_1R(struct acpi_walk_state *walk_state)
*/
return_desc =
acpi_ut_create_integer_object((u64)
temp_desc->
buffer.
pointer
[operand
[0]->
reference.
value]);
temp_desc->buffer.pointer[operand[0]->reference.value]);
if (!return_desc) {
status = AE_NO_MEMORY;
goto cleanup;
Expand Down
9 changes: 4 additions & 5 deletions drivers/acpi/acpica/exregion.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ acpi_ex_system_memory_space_handler(u32 function,
*/
page_boundary_map_length =
ACPI_ROUND_UP(address, ACPI_DEFAULT_PAGE_SIZE) - address;

if (page_boundary_map_length == 0) {
page_boundary_map_length = ACPI_DEFAULT_PAGE_SIZE;
}
Expand Down Expand Up @@ -240,19 +239,19 @@ acpi_ex_system_memory_space_handler(u32 function,

switch (bit_width) {
case 8:
ACPI_SET8(logical_addr_ptr) = (u8) * value;
ACPI_SET8(logical_addr_ptr) = (u8)*value;
break;

case 16:
ACPI_SET16(logical_addr_ptr) = (u16) * value;
ACPI_SET16(logical_addr_ptr) = (u16)*value;
break;

case 32:
ACPI_SET32(logical_addr_ptr) = (u32) * value;
ACPI_SET32(logical_addr_ptr) = (u32)*value;
break;

case 64:
ACPI_SET64(logical_addr_ptr) = (u64) * value;
ACPI_SET64(logical_addr_ptr) = (u64)*value;
break;

default:
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/acpica/hwacpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ acpi_status acpi_hw_set_mode(u32 mode)
* enable bits to default
*/
status = acpi_hw_write_port(acpi_gbl_FADT.smi_command,
(u32) acpi_gbl_FADT.acpi_disable,
8);
(u32)acpi_gbl_FADT.acpi_disable, 8);
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
"Attempting to enable Legacy (non-ACPI) mode\n"));
break;
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/acpica/hwregs.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,7 @@ acpi_status acpi_hw_write_pm1_control(u32 pm1a_control, u32 pm1b_control)
* DESCRIPTION: Read from the specified ACPI register
*
******************************************************************************/
acpi_status
acpi_hw_register_read(u32 register_id, u32 * return_value)
acpi_status acpi_hw_register_read(u32 register_id, u32 *return_value)
{
u32 value = 0;
acpi_status status;
Expand Down
3 changes: 2 additions & 1 deletion drivers/acpi/acpica/nsrepair2.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ ACPI_MODULE_NAME("nsrepair2")
*/
typedef
acpi_status(*acpi_repair_function) (struct acpi_predefined_data *data,
union acpi_operand_object **return_object_ptr);
union acpi_operand_object
**return_object_ptr);

typedef struct acpi_repair_info {
char name[ACPI_NAME_SIZE];
Expand Down
6 changes: 3 additions & 3 deletions drivers/acpi/acpica/nsutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ acpi_ns_print_node_pathname(struct acpi_namespace_node *node,
u8 acpi_ns_valid_root_prefix(char prefix)
{

return ((u8) (prefix == '\\'));
return ((u8)(prefix == '\\'));
}

/*******************************************************************************
Expand All @@ -129,7 +129,7 @@ u8 acpi_ns_valid_root_prefix(char prefix)
static u8 acpi_ns_valid_path_separator(char sep)
{

return ((u8) (sep == '.'));
return ((u8)(sep == '.'));
}

/*******************************************************************************
Expand Down Expand Up @@ -673,7 +673,7 @@ u32 acpi_ns_opens_scope(acpi_object_type type)
return_UINT32(ACPI_NS_NORMAL);
}

return_UINT32(((u32) acpi_gbl_ns_properties[type]) & ACPI_NS_NEWSCOPE);
return_UINT32(((u32)acpi_gbl_ns_properties[type]) & ACPI_NS_NEWSCOPE);
}

/*******************************************************************************
Expand Down
2 changes: 2 additions & 0 deletions drivers/acpi/acpica/nsxfeval.c
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,9 @@ acpi_ns_get_device_callback(acpi_handle obj_handle,
for (i = 0; i < cid->count; i++) {
if (ACPI_STRCMP(cid->ids[i].string, info->hid)
== 0) {

/* Found a matching CID */

found = TRUE;
break;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/psutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ u8 acpi_ps_is_leading_char(u32 c)
*/
u8 acpi_ps_is_prefix_char(u32 c)
{
return ((u8) (c == '\\' || c == '^'));
return ((u8)(c == '\\' || c == '^'));
}

/*
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/acpica/rscreate.c
Original file line number Diff line number Diff line change
Expand Up @@ -480,8 +480,7 @@ acpi_rs_create_aml_resources(struct acpi_resource *linked_list_buffer,
status = acpi_rs_get_aml_length(linked_list_buffer, &aml_size_needed);

ACPI_DEBUG_PRINT((ACPI_DB_INFO, "AmlSizeNeeded=%X, %s\n",
(u32) aml_size_needed,
acpi_format_exception(status)));
(u32)aml_size_needed, acpi_format_exception(status)));
if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status);
}
Expand Down
3 changes: 2 additions & 1 deletion drivers/acpi/acpica/rsdump.c
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,8 @@ acpi_rs_dump_descriptor(void *resource, struct acpi_rsdump_info *table)
/*
* Optional resource_source for Address resources
*/
acpi_rs_dump_resource_source(ACPI_CAST_PTR(struct
acpi_rs_dump_resource_source(ACPI_CAST_PTR
(struct
acpi_resource_source,
target));
break;
Expand Down
6 changes: 2 additions & 4 deletions drivers/acpi/acpica/rsirq.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,13 @@ struct acpi_rsconvert_info acpi_rs_convert_ext_irq[9] = {

{ACPI_RSC_COUNT, ACPI_RS_OFFSET(data.extended_irq.interrupt_count),
AML_OFFSET(extended_irq.interrupt_count),
sizeof(u32)}
,
sizeof(u32)},

/* Copy every IRQ in the table, each is 32 bits */

{ACPI_RSC_MOVE32, ACPI_RS_OFFSET(data.extended_irq.interrupts[0]),
AML_OFFSET(extended_irq.interrupts[0]),
0}
,
0},

/* Optional resource_source (Index and String) */

Expand Down
6 changes: 2 additions & 4 deletions drivers/acpi/acpica/rsmemory.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,7 @@ struct acpi_rsconvert_info acpi_rs_get_vendor_small[3] = {

{ACPI_RSC_COUNT16, ACPI_RS_OFFSET(data.vendor.byte_length),
0,
sizeof(u8)}
,
sizeof(u8)},

/* Vendor data */

Expand All @@ -181,8 +180,7 @@ struct acpi_rsconvert_info acpi_rs_get_vendor_large[3] = {

{ACPI_RSC_COUNT16, ACPI_RS_OFFSET(data.vendor.byte_length),
0,
sizeof(u8)}
,
sizeof(u8)},

/* Vendor data */

Expand Down
11 changes: 6 additions & 5 deletions drivers/acpi/acpica/rsmisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ acpi_rs_convert_aml_to_resource(struct acpi_resource *resource,
case ACPI_RSC_COUNT:

item_count = ACPI_GET8(source);
ACPI_SET8(destination) = (u8) item_count;
ACPI_SET8(destination) = (u8)item_count;

resource->length = resource->length +
(info->value * (item_count - 1));
Expand Down Expand Up @@ -385,7 +385,7 @@ acpi_rs_convert_aml_to_resource(struct acpi_resource *resource,
}

target = ACPI_ADD_PTR(char, resource, info->value);
ACPI_SET8(target) = (u8) item_count;
ACPI_SET8(target) = (u8)item_count;
break;

case ACPI_RSC_BITMASK16:
Expand All @@ -401,7 +401,7 @@ acpi_rs_convert_aml_to_resource(struct acpi_resource *resource,
}

target = ACPI_ADD_PTR(char, resource, info->value);
ACPI_SET8(target) = (u8) item_count;
ACPI_SET8(target) = (u8)item_count;
break;

case ACPI_RSC_EXIT_NE:
Expand Down Expand Up @@ -544,7 +544,7 @@ acpi_rs_convert_resource_to_aml(struct acpi_resource *resource,
case ACPI_RSC_COUNT:

item_count = ACPI_GET8(source);
ACPI_SET8(destination) = (u8) item_count;
ACPI_SET8(destination) = (u8)item_count;

aml_length =
(u16) (aml_length +
Expand Down Expand Up @@ -686,7 +686,8 @@ acpi_rs_convert_resource_to_aml(struct acpi_resource *resource,
* Optional resource_source (Index and String)
*/
aml_length =
acpi_rs_set_resource_source(aml, (acpi_rs_length)
acpi_rs_set_resource_source(aml,
(acpi_rs_length)
aml_length, source);
acpi_rs_set_resource_length(aml_length, aml);
break;
Expand Down
6 changes: 4 additions & 2 deletions drivers/acpi/acpica/rsutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,10 @@ acpi_rs_get_resource_source(acpi_rs_length resource_length,
*
* Zero the entire area of the buffer.
*/
total_length = (u32)
ACPI_STRLEN(ACPI_CAST_PTR(char, &aml_resource_source[1])) + 1;
total_length =
(u32)
ACPI_STRLEN(ACPI_CAST_PTR(char, &aml_resource_source[1])) +
1;
total_length = (u32) ACPI_ROUND_UP_TO_NATIVE_WORD(total_length);

ACPI_MEMSET(resource_source->string_ptr, 0, total_length);
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/acpica/uteval.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ ACPI_MODULE_NAME("uteval")
******************************************************************************/

acpi_status
acpi_ut_evaluate_object(struct acpi_namespace_node *prefix_node,
acpi_ut_evaluate_object(struct acpi_namespace_node * prefix_node,
char *path,
u32 expected_return_btypes,
union acpi_operand_object **return_desc)
Expand Down
1 change: 1 addition & 0 deletions drivers/acpi/acpica/utglobal.c
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ acpi_status acpi_ut_init_globals(void)
}

/* Public globals */

ACPI_EXPORT_SYMBOL(acpi_gbl_FADT)
ACPI_EXPORT_SYMBOL(acpi_dbg_level)
ACPI_EXPORT_SYMBOL(acpi_dbg_layer)
Expand Down
7 changes: 3 additions & 4 deletions drivers/acpi/acpica/utresrc.c
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ static const u8 acpi_gbl_resource_types[] = {
******************************************************************************/

acpi_status
acpi_ut_walk_aml_resources(u8 * aml,
acpi_ut_walk_aml_resources(u8 *aml,
acpi_size aml_length,
acpi_walk_aml_callback user_function, void **context)
{
Expand Down Expand Up @@ -525,7 +525,7 @@ acpi_ut_walk_aml_resources(u8 * aml,
*
******************************************************************************/

acpi_status acpi_ut_validate_resource(void *aml, u8 * return_index)
acpi_status acpi_ut_validate_resource(void *aml, u8 *return_index)
{
union aml_resource *aml_resource;
u8 resource_type;
Expand Down Expand Up @@ -800,8 +800,7 @@ u32 acpi_ut_get_descriptor_length(void *aml)
******************************************************************************/

acpi_status
acpi_ut_get_resource_end_tag(union acpi_operand_object * obj_desc,
u8 ** end_tag)
acpi_ut_get_resource_end_tag(union acpi_operand_object *obj_desc, u8 **end_tag)
{
acpi_status status;

Expand Down
4 changes: 1 addition & 3 deletions include/acpi/acpiosxf.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,8 @@ acpi_os_physical_table_override(struct acpi_table_header *existing_table,
/*
* Spinlock primitives
*/

#ifndef acpi_os_create_lock
acpi_status
acpi_os_create_lock(acpi_spinlock *out_handle);
acpi_status acpi_os_create_lock(acpi_spinlock * out_handle);
#endif

void acpi_os_delete_lock(acpi_spinlock handle);
Expand Down
4 changes: 4 additions & 0 deletions include/acpi/acpixf.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,14 @@ extern u32 acpi_current_gpe_count;
extern struct acpi_table_fadt acpi_gbl_FADT;
extern u8 acpi_gbl_system_awake_and_running;
extern u8 acpi_gbl_reduced_hardware; /* ACPI 5.0 */

/* Runtime configuration of debug print levels */

extern u32 acpi_dbg_level;
extern u32 acpi_dbg_layer;

/* ACPICA runtime options */

extern u8 acpi_gbl_enable_interpreter_slack;
extern u8 acpi_gbl_all_methods_serialized;
extern u8 acpi_gbl_create_osi_method;
Expand Down
1 change: 0 additions & 1 deletion include/acpi/actbl.h
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ struct acpi_table_desc {
/*
* Get the remaining ACPI tables
*/

#include <acpi/actbl1.h>
#include <acpi/actbl2.h>
#include <acpi/actbl3.h>
Expand Down
Loading

0 comments on commit 3e8214e

Please sign in to comment.