Skip to content

Commit

Permalink
cpufreq: governor: Simplify cpufreq_governor_limits()
Browse files Browse the repository at this point in the history
Use the observation that cpufreq_governor_limits() doesn't have to
get to the policy object it wants to manipulate by walking the
reference chain cdbs->policy_dbs->policy, as the final pointer is
actually equal to its argument, and make it access the policy
object directy via its argument.

Signed-off-by: Rafael J. Wysocki <[email protected]>
Acked-by: Viresh Kumar <[email protected]>
  • Loading branch information
rafaeljw committed Mar 9, 2016
1 parent d10b5eb commit e975189
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions drivers/cpufreq/cpufreq_governor.c
Original file line number Diff line number Diff line change
Expand Up @@ -519,20 +519,19 @@ static int cpufreq_governor_limits(struct cpufreq_policy *policy)
{
struct dbs_governor *gov = dbs_governor_of(policy);
struct cpu_dbs_info *cdbs = gov->get_cpu_cdbs(policy->cpu);
struct policy_dbs_info *policy_dbs = cdbs->policy_dbs;

/* State should be equivalent to START */
if (!cdbs->policy_dbs || !cdbs->policy_dbs->policy)
if (!policy_dbs || !policy_dbs->policy)
return -EBUSY;

mutex_lock(&cdbs->policy_dbs->timer_mutex);
if (policy->max < cdbs->policy_dbs->policy->cur)
__cpufreq_driver_target(cdbs->policy_dbs->policy, policy->max,
CPUFREQ_RELATION_H);
else if (policy->min > cdbs->policy_dbs->policy->cur)
__cpufreq_driver_target(cdbs->policy_dbs->policy, policy->min,
CPUFREQ_RELATION_L);
mutex_lock(&policy_dbs->timer_mutex);
if (policy->max < policy->cur)
__cpufreq_driver_target(policy, policy->max, CPUFREQ_RELATION_H);
else if (policy->min > policy->cur)
__cpufreq_driver_target(policy, policy->min, CPUFREQ_RELATION_L);
dbs_check_cpu(policy);
mutex_unlock(&cdbs->policy_dbs->timer_mutex);
mutex_unlock(&policy_dbs->timer_mutex);

return 0;
}
Expand Down

0 comments on commit e975189

Please sign in to comment.