crypto: crc32c - Fix crc32c soft dependency

I don't think it makes sense for a module to have a soft dependency on itself. This seems quite cyclic by nature and I can't see what purpose it could serve. OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty much assumes that some incarnation of the "crc32c" hash algorithm has been loaded. Therefore it makes sense to have the soft dependency there (as crc-t10dif does.) Cc: [email protected] Cc: Tim Chen <[email protected]> Cc: "David S. Miller" <[email protected]> Signed-off-by: Jean Delvare <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
zubinmehta · Jan 19, 2016 · fd7f672 · fd7f672
1 parent 4f0414e
commit fd7f672
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/crypto/crc32c_generic.c b/crypto/crc32c_generic.c
@@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations wrapper for lib/crc32c");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CRYPTO("crc32c");
 MODULE_ALIAS_CRYPTO("crc32c-generic");
-MODULE_SOFTDEP("pre: crc32c");
diff --git a/lib/libcrc32c.c b/lib/libcrc32c.c
@@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini);
 MODULE_AUTHOR("Clay Haapala <[email protected]>");
 MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
 MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: crc32c");