forked from thales-markets/thales-improvement-proposals
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
| id | Title | Status | Author | Description | Discussions to | Created | | ||
| ----------- | ----------- | ----------- | ----------- | ----------- | ----------- | ----------- | | ||
| TIP-103 | Deprecate the SELL funticion on Overtime | Draft | @scvija @gruja | Deprecate the SELL funticion on Overtime | https://discord.gg/rPpPcMXSeU | 2022-11-16 | ||
|
||
|
||
## Abstract | ||
|
||
This TIP proposes a plan to deprecate the sell function on Overtime | ||
|
||
## Motivation | ||
|
||
|
||
The Overtime sports AMM was built on the same basis that the Thales crypto AMM uses, and therefore it allowed the users to both buy positions and sell them before expiry. For the crypto AMM, this is something that always made sense, the users could buy certain positions, and depending on the movement of the market, they could either take profits or cut their losses, instead of holding the position until the expiration date. The same principle was taken over to the Overtime AMM, and selling bought Overtime positions was made possible, being something truly unique in the space. | ||
|
||
Overtime has been running since July/August 2022 with great success, achieving 2.14 million USD in volume, with 22,748 unique transactions. | ||
Out of these 22,748, only 806 were SELL transactions, accounting only for 3.5% of the total transactions. This information can ne checked using Dune: | ||
[Total transactions](https://dune.com/queries/1046887/1804805) | ||
[Sell transactions](https://dune.com/queries/1469435) | ||
From these 806, around 600 were immediate sells, being essentially wash trades, a way of gaming the system for rewards and volume-based incentives. | ||
![This is an image](image.png) | ||
Aside from that, there were a lot of examples of users buying and selling positions immediately, to claim a Galxe OAT/POAP. | ||
|
||
Another reason for the deprecation of the selling mechanism is - even if the sell volume is low, the codebase still needs to be maintained, and even more important, it takes up the already limited space in the SportsAMM contract. | ||
|
||
The final reasons are the upcoming features of the Overtime platform, like the addition of spread and player props. In this case, the spread or amount of points for a player could change (for example LeBron James from 25.5 to 27.5), opening more possibilities for manipulations. | ||
|
||
|
||
|
||
## Specification | ||
|
||
This implementation will mean that the following methods will be removed from the contract: | ||
|
||
- sellToAMM | ||
- availableToSellToAMM | ||
- sellToAmmQuote | ||
- sellPriceImpact | ||
- all child internal methods that are called inside of those functions | ||
|
||
## Implementation | ||
|
||
n/a | ||
|
||
## Copyright | ||
|
||
Copyright and related rights waived via CC0. |