Skip to content

Commit

Permalink
Rename Traditional Gradebook label to Gradebook
Browse files Browse the repository at this point in the history
flag=none

Change-Id: I16e28812475ab71b1591fcfe9b0eaab72cae3d42
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275638
Tested-by: Service Cloud Jenkins <[email protected]>
Reviewed-by: Syed Hussain <[email protected]>
Reviewed-by: Eduardo Escobar <[email protected]>
QA-Review: Dustin Cowles <[email protected]>
Product-Review: Syed Hussain <[email protected]>
  • Loading branch information
aaronshaf committed Oct 13, 2021
1 parent 015d7ab commit 5453a0a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
11 changes: 4 additions & 7 deletions ui/shared/gradebook-menu/react/__tests__/gradebook_menu.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('GradebookMenu', () => {
const {getAllByRole, getByRole} = render(<GradebookMenu {...defaultProps} />)
const menu = getByRole('button')

expect(menu).toHaveTextContent('Traditional Gradebook')
expect(menu).toHaveTextContent('Gradebook')
fireEvent.click(menu)

checkMenuItemContents(
Expand Down Expand Up @@ -89,7 +89,7 @@ describe('GradebookMenu', () => {

checkMenuItemContents(
getAllByRole('menuitem'),
['Traditional Gradebook…', 'Individual Gradebook…', 'Gradebook History…'],
['Gradebook…', 'Individual Gradebook…', 'Gradebook History…'],
[
'/courseUrl/gradebook?view=gradebook',
'/courseUrl/gradebook/change_gradebook_version?version=individual',
Expand All @@ -111,7 +111,7 @@ describe('GradebookMenu', () => {

checkMenuItemContents(
getAllByRole('menuitem'),
['Traditional Gradebook…', 'Individual Gradebook…', 'Learning Mastery…'],
['Gradebook…', 'Individual Gradebook…', 'Learning Mastery…'],
[
'/courseUrl/gradebook?view=gradebook',
'/courseUrl/gradebook/change_gradebook_version?version=individual',
Expand All @@ -131,10 +131,7 @@ describe('GradebookMenu', () => {
const menu = getByRole('button')
fireEvent.click(menu)

checkMenuItemContents(getAllByRole('menuitem'), [
'Traditional Gradebook…',
'Individual Gradebook…'
])
checkMenuItemContents(getAllByRole('menuitem'), ['Gradebook…', 'Individual Gradebook…'])
})
})
})
4 changes: 2 additions & 2 deletions ui/shared/gradebook-menu/react/gradebook_menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ type VariantMap = {

const variants: VariantMap = {
DefaultGradebook: {
activeLabel: I18n.t('Traditional Gradebook'),
activeLabel: I18n.t('Gradebook'),
activeOptions: [
'DefaultGradebookLearningMastery',
'IndividualGradebook',
Expand All @@ -62,7 +62,7 @@ const variants: VariantMap = {
],
href: courseUrl => `${courseUrl}/gradebook?view=gradebook`,
key: 'default-gradebook',
menuLabel: I18n.t('Traditional Gradebook…')
menuLabel: I18n.t('Gradebook…')
},
DefaultGradebookLearningMastery: {
activeLabel: I18n.t('Learning Mastery'),
Expand Down

0 comments on commit 5453a0a

Please sign in to comment.