Set err_msg on _libssh2_wait_socket errors (libssh2#135)

zxfrocky · Oct 19, 2016 · 15851ba · 15851ba
1 parent c4c60ea
commit 15851ba
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/session.c b/src/session.c
@@ -603,8 +603,8 @@ int _libssh2_wait_socket(LIBSSH2_SESSION *session, time_t start_time)
         time_t now = time (NULL);
         elapsed_ms = (long)(1000*difftime(now, start_time));
         if (elapsed_ms > session->api_timeout) {
-            session->err_code = LIBSSH2_ERROR_TIMEOUT;
-            return LIBSSH2_ERROR_TIMEOUT;
+            return _libssh2_error(session, LIBSSH2_ERROR_TIMEOUT,
+                                  "API timeout expired");
         }
         ms_to_next = (session->api_timeout - elapsed_ms);
         has_timeout = 1;
@@ -658,10 +658,13 @@ int _libssh2_wait_socket(LIBSSH2_SESSION *session, time_t start_time)
                     has_timeout ? &tv : NULL);
     }
 #endif
-    if(rc <= 0) {
-        /* timeout (or error), bail out with a timeout error */
-        session->err_code = LIBSSH2_ERROR_TIMEOUT;
-        return LIBSSH2_ERROR_TIMEOUT;
+    if(rc == 0) {
+        return _libssh2_error(session, LIBSSH2_ERROR_TIMEOUT,
+                              "Timed out waiting on socket");
+    }
+    if(rc < 0) {
+        return _libssh2_error(session, LIBSSH2_ERROR_TIMEOUT,
+                              "Error waiting on socket");
     }
 
     return 0; /* ready to try again */