upgrade eslint & its ilk

- also upgrade `lint-staged`, because it's broken for some reason
- reformat
- lint
- remove `prettier-eslint-cli`
- update formatting command to handle JSON & YAML files via prettier,
  and eslint for everything else
- update `.lintstagedrc` to deal as well

test file changes are related to deprecations of various `assert` methods

.eslintrc.yml

@@ -9,7 +9,6 @@ parserOptions:
   ecmaVersion: 5
   ecmaFeatures:
     globalReturn: no
-    experimentalObjectRestSpread: no
     jsx: no
   sourceType: script
 rules:
@@ -18,30 +17,25 @@ rules:
     - safe
 overrides:
   - files:
-    - scripts/**/*.js
-    - package-scripts.js
-    - karma.conf.js
-    - .wallaby.js
-    - bin/*
-    - lib/cli/**/*.js
-    - test/node-unit/**/*.js
+      - scripts/**/*.js
+      - package-scripts.js
+      - karma.conf.js
+      - .wallaby.js
+      - bin/*
+      - lib/cli/**/*.js
+      - test/node-unit/**/*.js
     parserOptions:
       ecmaVersion: 6
     env:
       browser: no
   - files:
-    - test/**/*.{js,mjs}
+      - test/**/*.{js,mjs}
     env:
       mocha: yes
     globals:
       expect: no
   - files:
-    - doc/**/*.js
-    env:
-      node: no
-  - files:
-    - test/**/*.mjs
+      - test/**/*.mjs
     parserOptions:
       ecmaVersion: 6
       sourceType: module
-

.lintstagedrc.json

@@ -1,6 +1,7 @@
 {
   "linters": {
-    "(bin/*|*.{js,json}|**/*.{js,json})": ["prettier-eslint --write", "git add"]
+    "(bin/*|*.js|**/*.js)": ["eslint --fix", "git add"],
+    "(*.{json,yml}|**/*.{json,yml})": ["prettier --write", "git add"]
   },
   "ignore": ["docs/**/*.js", "test/**/*.fixture.js", "package*.json"]
 }

.travis.yml

@@ -15,7 +15,7 @@ node_js: '11'
 addons:
   apt:
     packages:
-    - libnotify-bin
+      - libnotify-bin
 # `nvm install` happens before the cache is restored, which means
 # we must install our own npm elsewhere (`~/npm`)
 before_install: |

karma.conf.js

@@ -31,8 +31,7 @@ module.exports = config => {
     browserify: {
       debug: true,
       configure: function configure(b) {
-        b
-          .ignore('glob')
+        b.ignore('glob')
           .ignore('fs')
           .ignore('path')
           .ignore('supports-color')

lib/reporters/html.js

@@ -232,7 +232,7 @@ function HTML(runner) {
 
   function updateStats() {
     // TODO: add to stats
-    var percent = (stats.tests / runner.total * 100) | 0;
+    var percent = ((stats.tests / runner.total) * 100) | 0;
     if (progress) {
       progress.update(percent).draw(ctx);
     }

lib/reporters/landing.js

@@ -67,7 +67,7 @@ function Landing(runner) {
 
   runner.on('test end', function(test) {
     // check if the plane crashed
-    var col = crashed === -1 ? (width * ++n / total) | 0 : crashed;
+    var col = crashed === -1 ? ((width * ++n) / total) | 0 : crashed;
 
     // show the crash
     if (test.state === 'failed') {

lib/runner.js

@@ -710,9 +710,9 @@ Runner.prototype.uncaught = function(err) {
     debug(
       'uncaught exception %s',
       err ===
-      function() {
-        return this;
-      }.call(err)
+        function() {
+          return this;
+        }.call(err)
         ? err.message || err
         : err
     );

lib/utils.js

@@ -91,8 +91,7 @@ exports.files = function(dir, ext, ret) {
 
   var re = new RegExp('\\.(' + ext.join('|') + ')$');
 
-  fs
-    .readdirSync(dir)
+  fs.readdirSync(dir)
     .filter(ignored)
     .forEach(function(path) {
       path = join(dir, path);