Skip to content

Commit

Permalink
Change types.go to set managed-by label's value of kubevirt
Browse files Browse the repository at this point in the history
components to be virt-operator instead of kubevirt-operator,
since the operator name is virt-operator.
Change the tests to expept managed-by label's value of kubevirt
components to be virt-operator instead of kubevirt-operator,
since the operator name is virt-operator.

Signed-off-by: Barak Mordehai <[email protected]>
  • Loading branch information
Barakmor1 committed Dec 6, 2021
1 parent 79036e9 commit 1884aa7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/virt-operator/resource/apply/apps_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ var _ = Describe("Apply Apps", func() {
managedBy, ok := deployment.Labels["app.kubernetes.io/managed-by"]

Expect(ok).To(BeTrue())
Expect(managedBy).To(Equal("kubevirt-operator"))
Expect(managedBy).To(Equal("virt-operator"))

version, ok := deployment.Annotations["kubevirt.io/install-strategy-version"]
Expect(ok).To(BeTrue())
Expand Down
2 changes: 1 addition & 1 deletion pkg/virt-operator/resource/apply/reconcile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ var _ = Describe("Apply", func() {
managedBy, ok := deployment.Labels["app.kubernetes.io/managed-by"]

Expect(ok).To(BeTrue())
Expect(managedBy).To(Equal("kubevirt-operator"))
Expect(managedBy).To(Equal("virt-operator"))

version, ok := deployment.Annotations["kubevirt.io/install-strategy-version"]
Expect(ok).To(BeTrue())
Expand Down
2 changes: 1 addition & 1 deletion staging/src/kubevirt.io/api/core/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ const (
AppComponent = "kubevirt"
// This label will be set on all resources created by the operator
ManagedByLabel = AppLabelPrefix + "/managed-by"
ManagedByLabelOperatorValue = "kubevirt-operator"
ManagedByLabelOperatorValue = "virt-operator"
// This annotation represents the kubevirt version for an install strategy configmap.
InstallStrategyVersionAnnotation = "kubevirt.io/install-strategy-version"
// This annotation represents the kubevirt registry used for an install strategy configmap.
Expand Down

0 comments on commit 1884aa7

Please sign in to comment.