Skip to content

Commit

Permalink
Add SigCompute decorator to related tests
Browse files Browse the repository at this point in the history
Not all occurrences of `[sig-compute]` were paired with the decorator `SigCompute`.
This is because in some files the `[sig-compute]` tag was already present in the parent spec.

Signed-off-by: fossedihelm <[email protected]>
  • Loading branch information
fossedihelm committed Jan 4, 2023
1 parent 359dd13 commit 2c18a95
Show file tree
Hide file tree
Showing 58 changed files with 146 additions and 54 deletions.
4 changes: 3 additions & 1 deletion tests/access_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import (
"context"
"fmt"

"kubevirt.io/kubevirt/tests/decorators"

"kubevirt.io/kubevirt/tests/clientcmd"
"kubevirt.io/kubevirt/tests/framework/checks"
"kubevirt.io/kubevirt/tests/testsuite"
Expand Down Expand Up @@ -157,7 +159,7 @@ func (r rights) list() (e []rightsEntry) {
return
}

var _ = Describe("[rfe_id:500][crit:high][arm64][vendor:[email protected]][level:component][sig-compute]User Access", func() {
var _ = Describe("[rfe_id:500][crit:high][arm64][vendor:[email protected]][level:component][sig-compute]User Access", decorators.SigCompute, func() {

var k8sClient string
var authClient *authClientV1.AuthorizationV1Client
Expand Down
4 changes: 3 additions & 1 deletion tests/clone_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

virtsnapshot "kubevirt.io/api/snapshot"
"kubevirt.io/api/snapshot/v1alpha1"

Expand Down Expand Up @@ -40,7 +42,7 @@ const (

type loginFunction func(*virtv1.VirtualMachineInstance) error

var _ = Describe("[Serial][sig-compute]VirtualMachineClone Tests", Serial, func() {
var _ = Describe("[Serial][sig-compute]VirtualMachineClone Tests", Serial, decorators.SigCompute, func() {
var err error
var virtClient kubecli.KubevirtClient

Expand Down
4 changes: 3 additions & 1 deletion tests/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

k8sv1 "k8s.io/api/core/v1"

expect "github.com/google/goexpect"
Expand All @@ -45,7 +47,7 @@ import (
"kubevirt.io/kubevirt/tests/libvmi"
)

var _ = Describe("[rfe_id:899][crit:medium][vendor:[email protected]][level:component][sig-compute]Config", func() {
var _ = Describe("[rfe_id:899][crit:medium][vendor:[email protected]][level:component][sig-compute]Config", decorators.SigCompute, func() {

var virtClient kubecli.KubevirtClient

Expand Down
2 changes: 1 addition & 1 deletion tests/console_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func withNodeAffinityTo(label string, value string) libvmi.Option {
}
}

var _ = Describe("[rfe_id:127][posneg:negative][crit:medium][vendor:[email protected]][level:component][sig-compute]Console", func() {
var _ = Describe("[rfe_id:127][posneg:negative][crit:medium][vendor:[email protected]][level:component][sig-compute]Console", decorators.SigCompute, func() {

var virtClient kubecli.KubevirtClient

Expand Down
4 changes: 3 additions & 1 deletion tests/container_disk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

expect "github.com/google/goexpect"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
Expand All @@ -47,7 +49,7 @@ import (
"kubevirt.io/kubevirt/tests/libwait"
)

var _ = Describe("[rfe_id:588][crit:medium][vendor:[email protected]][level:component][sig-compute]ContainerDisk", func() {
var _ = Describe("[rfe_id:588][crit:medium][vendor:[email protected]][level:component][sig-compute]ContainerDisk", decorators.SigCompute, func() {

var virtClient kubecli.KubevirtClient
var err error
Expand Down
4 changes: 3 additions & 1 deletion tests/credentials_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import (
"fmt"
"time"

"kubevirt.io/kubevirt/tests/decorators"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

Expand All @@ -42,7 +44,7 @@ import (
cd "kubevirt.io/kubevirt/tests/containerdisk"
)

var _ = Describe("[sig-compute]Guest Access Credentials", func() {
var _ = Describe("[sig-compute]Guest Access Credentials", decorators.SigCompute, func() {

var err error
var virtClient kubecli.KubevirtClient
Expand Down
2 changes: 1 addition & 1 deletion tests/dryrun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import (
"kubevirt.io/kubevirt/tests/util"
)

var _ = Describe("[sig-compute]Dry-Run requests", func() {
var _ = Describe("[sig-compute]Dry-Run requests", decorators.SigCompute, func() {
var err error
var virtClient kubecli.KubevirtClient
var restClient *rest.RESTClient
Expand Down
4 changes: 3 additions & 1 deletion tests/hyperv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

virtconfig "kubevirt.io/kubevirt/pkg/virt-config"

"kubevirt.io/kubevirt/pkg/virt-controller/services"
Expand Down Expand Up @@ -33,7 +35,7 @@ import (
"kubevirt.io/kubevirt/tests/util"
)

var _ = Describe("[Serial][sig-compute] Hyper-V enlightenments", Serial, func() {
var _ = Describe("[Serial][sig-compute] Hyper-V enlightenments", Serial, decorators.SigCompute, func() {

var (
virtClient kubecli.KubevirtClient
Expand Down
4 changes: 3 additions & 1 deletion tests/infra_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

virtconfig "kubevirt.io/kubevirt/pkg/virt-config"

kvtls "kubevirt.io/kubevirt/pkg/util/tls"
Expand Down Expand Up @@ -93,7 +95,7 @@ const (
remoteCmdErrPattern = "failed running `%s` with stdout:\n %v \n stderr:\n %v \n err: \n %v \n"
)

var _ = Describe("[Serial][sig-compute]Infrastructure", Serial, func() {
var _ = Describe("[Serial][sig-compute]Infrastructure", Serial, decorators.SigCompute, func() {
var (
virtClient kubecli.KubevirtClient
aggregatorClient *aggregatorclient.Clientset
Expand Down
4 changes: 3 additions & 1 deletion tests/instancetype_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import (
goerrors "errors"
"time"

"kubevirt.io/kubevirt/tests/decorators"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

Expand Down Expand Up @@ -33,7 +35,7 @@ import (
"kubevirt.io/kubevirt/tests/util"
)

var _ = Describe("[crit:medium][vendor:[email protected]][level:component][sig-compute] Instancetype and Preferences", func() {
var _ = Describe("[crit:medium][vendor:[email protected]][level:component][sig-compute] Instancetype and Preferences", decorators.SigCompute, func() {

var (
virtClient kubecli.KubevirtClient
Expand Down
4 changes: 3 additions & 1 deletion tests/kubectl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

"kubevirt.io/kubevirt/tests/framework/checks"
"kubevirt.io/kubevirt/tests/testsuite"

Expand All @@ -24,7 +26,7 @@ import (
"kubevirt.io/kubevirt/tests"
)

var _ = Describe("[sig-compute]oc/kubectl integration", func() {
var _ = Describe("[sig-compute]oc/kubectl integration", decorators.SigCompute, func() {
var (
k8sClient, result string
err error
Expand Down
1 change: 1 addition & 0 deletions tests/launchsecurity/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ go_library(
"//staging/src/kubevirt.io/client-go/kubecli:go_default_library",
"//tests:go_default_library",
"//tests/console:go_default_library",
"//tests/decorators:go_default_library",
"//tests/framework/checks:go_default_library",
"//tests/libvmi:go_default_library",
"//vendor/github.com/google/goexpect:go_default_library",
Expand Down
4 changes: 3 additions & 1 deletion tests/launchsecurity/sev.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
"fmt"
"time"

"kubevirt.io/kubevirt/tests/decorators"

expect "github.com/google/goexpect"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
Expand All @@ -19,7 +21,7 @@ import (
"kubevirt.io/kubevirt/tests/libvmi"
)

var _ = Describe("[sig-compute]AMD Secure Encrypted Virtualization (SEV)", func() {
var _ = Describe("[sig-compute]AMD Secure Encrypted Virtualization (SEV)", decorators.SigCompute, func() {
BeforeEach(func() {
checks.SkipTestIfNoFeatureGate(virtconfig.WorkloadEncryptionSEV)
})
Expand Down
2 changes: 1 addition & 1 deletion tests/mdev_configuration_allocation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import (
"kubevirt.io/kubevirt/tests/libwait"
)

var _ = Describe("[Serial][sig-compute]MediatedDevices", Serial, decorators.VGPU, func() {
var _ = Describe("[Serial][sig-compute]MediatedDevices", Serial, decorators.VGPU, decorators.SigCompute, func() {
var err error
var virtClient kubecli.KubevirtClient

Expand Down
2 changes: 1 addition & 1 deletion tests/migration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const (
stressDefaultTimeout = 1600
)

var _ = Describe("[rfe_id:393][crit:high][vendor:[email protected]][level:system][sig-compute] VM Live Migration", decorators.SigComputeMigrations, func() {
var _ = Describe("[rfe_id:393][crit:high][vendor:[email protected]][level:system][sig-compute] VM Live Migration", decorators.SigComputeMigrations, decorators.SigCompute, func() {
var virtClient kubecli.KubevirtClient
var migrationBandwidthLimit resource.Quantity
var err error
Expand Down
4 changes: 3 additions & 1 deletion tests/nonroot_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

"kubevirt.io/kubevirt/tests/decorators"

"kubevirt.io/client-go/kubecli"

virtconfig "kubevirt.io/kubevirt/pkg/virt-config"
Expand All @@ -15,7 +17,7 @@ import (
"kubevirt.io/kubevirt/tests/util"
)

var _ = Describe("[sig-compute]NonRoot feature", func() {
var _ = Describe("[sig-compute]NonRoot feature", decorators.SigCompute, func() {

var virtClient kubecli.KubevirtClient
var err error
Expand Down
1 change: 1 addition & 0 deletions tests/numa/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ go_library(
"//staging/src/kubevirt.io/client-go/kubecli:go_default_library",
"//tests:go_default_library",
"//tests/console:go_default_library",
"//tests/decorators:go_default_library",
"//tests/exec:go_default_library",
"//tests/framework/checks:go_default_library",
"//tests/libnode:go_default_library",
Expand Down
4 changes: 3 additions & 1 deletion tests/numa/numa.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import (

"kubevirt.io/kubevirt/tests/libnode"

"kubevirt.io/kubevirt/tests/decorators"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
k8sv1 "k8s.io/api/core/v1"
Expand All @@ -30,7 +32,7 @@ import (
"kubevirt.io/kubevirt/tests/util"
)

var _ = Describe("[sig-compute][Serial]NUMA", Serial, func() {
var _ = Describe("[sig-compute][Serial]NUMA", Serial, decorators.SigCompute, func() {

var virtClient kubecli.KubevirtClient
BeforeEach(func() {
Expand Down
4 changes: 3 additions & 1 deletion tests/pausing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

"k8s.io/apimachinery/pkg/util/intstr"

"kubevirt.io/kubevirt/tests/framework/matcher"
Expand All @@ -51,7 +53,7 @@ import (
cd "kubevirt.io/kubevirt/tests/containerdisk"
)

var _ = Describe("[rfe_id:3064][crit:medium][vendor:[email protected]][level:component][sig-compute]Pausing", func() {
var _ = Describe("[rfe_id:3064][crit:medium][vendor:[email protected]][level:component][sig-compute]Pausing", decorators.SigCompute, func() {

var err error
var virtClient kubecli.KubevirtClient
Expand Down
4 changes: 3 additions & 1 deletion tests/pool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import (
"fmt"
"time"

"kubevirt.io/kubevirt/tests/decorators"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
corev1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -56,7 +58,7 @@ const (
newLabelValue = "newvalue"
)

var _ = Describe("[sig-compute]VirtualMachinePool", func() {
var _ = Describe("[sig-compute]VirtualMachinePool", decorators.SigCompute, func() {
var err error
var virtClient kubecli.KubevirtClient

Expand Down
4 changes: 3 additions & 1 deletion tests/portforward_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import (
"io"
"time"

"kubevirt.io/kubevirt/tests/decorators"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

Expand All @@ -35,7 +37,7 @@ import (
"kubevirt.io/kubevirt/tests/util"
)

var _ = Describe("[sig-compute]PortForward", func() {
var _ = Describe("[sig-compute]PortForward", decorators.SigCompute, func() {

var err error
var virtClient kubecli.KubevirtClient
Expand Down
4 changes: 3 additions & 1 deletion tests/replicaset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import (
"strings"
"time"

"kubevirt.io/kubevirt/tests/decorators"

"kubevirt.io/kubevirt/tests/clientcmd"
"kubevirt.io/kubevirt/tests/framework/checks"
"kubevirt.io/kubevirt/tests/framework/matcher"
Expand Down Expand Up @@ -53,7 +55,7 @@ import (
"kubevirt.io/kubevirt/tests"
)

var _ = Describe("[rfe_id:588][crit:medium][vendor:[email protected]][level:component][sig-compute]VirtualMachineInstanceReplicaSet", func() {
var _ = Describe("[rfe_id:588][crit:medium][vendor:[email protected]][level:component][sig-compute]VirtualMachineInstanceReplicaSet", decorators.SigCompute, func() {
var err error
var virtClient kubecli.KubevirtClient

Expand Down
1 change: 1 addition & 0 deletions tests/scale/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ go_library(
deps = [
"//pkg/virt-operator/resource/generate/components:go_default_library",
"//staging/src/kubevirt.io/client-go/kubecli:go_default_library",
"//tests/decorators:go_default_library",
"//tests/util:go_default_library",
"//vendor/github.com/onsi/ginkgo/v2:go_default_library",
"//vendor/github.com/onsi/gomega:go_default_library",
Expand Down
4 changes: 3 additions & 1 deletion tests/scale/virt-api.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"context"
"time"

"kubevirt.io/kubevirt/tests/decorators"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand All @@ -14,7 +16,7 @@ import (
"kubevirt.io/kubevirt/tests/util"
)

var _ = Describe("[sig-compute] virt-api scaling", func() {
var _ = Describe("[sig-compute] virt-api scaling", decorators.SigCompute, func() {

var virtClient kubecli.KubevirtClient

Expand Down
4 changes: 3 additions & 1 deletion tests/security_features_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import (
"fmt"
"strings"

"kubevirt.io/kubevirt/tests/decorators"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
k8sv1 "k8s.io/api/core/v1"
Expand All @@ -50,7 +52,7 @@ const (
capNetBindService k8sv1.Capability = "NET_BIND_SERVICE"
)

var _ = Describe("[Serial][sig-compute]SecurityFeatures", Serial, func() {
var _ = Describe("[Serial][sig-compute]SecurityFeatures", Serial, decorators.SigCompute, func() {
var err error
var virtClient kubecli.KubevirtClient

Expand Down
Loading

0 comments on commit 2c18a95

Please sign in to comment.