Merge pull request kubevirt#4988 from iholder-redhat/sonar_issue/dupl…

…ication_smbios [SonarCloud] Create constant to avoid string duplication
zyjj1 · Feb 11, 2021 · 483bef0 · 483bef0
2 parents bcde8e3 + a7026df
commit 483bef0
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/cmd/example-hook-sidecar/smbios.go b/cmd/example-hook-sidecar/smbios.go
@@ -39,7 +39,10 @@ import (
 	domainSchema "kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api"
 )
 
-const baseBoardManufacturerAnnotation = "smbios.vm.kubevirt.io/baseBoardManufacturer"
+const (
+	baseBoardManufacturerAnnotation = "smbios.vm.kubevirt.io/baseBoardManufacturer"
+	onDefineDomainLoggingMessage    = "Hook's OnDefineDomain callback method has been called"
+)
 
 type infoServer struct {
 	Version string
@@ -66,7 +69,7 @@ type v1alpha1Server struct{}
 type v1alpha2Server struct{}
 
 func (s v1alpha2Server) OnDefineDomain(ctx context.Context, params *hooksV1alpha2.OnDefineDomainParams) (*hooksV1alpha2.OnDefineDomainResult, error) {
-	log.Log.Info("Hook's OnDefineDomain callback method has been called")
+	log.Log.Info(onDefineDomainLoggingMessage)
 	newDomainXML, err := onDefineDomain(params.GetVmi(), params.GetDomainXML())
 	if err != nil {
 		return nil, err
@@ -82,7 +85,7 @@ func (s v1alpha2Server) PreCloudInitIso(_ context.Context, params *hooksV1alpha2
 }
 
 func (s v1alpha1Server) OnDefineDomain(ctx context.Context, params *hooksV1alpha1.OnDefineDomainParams) (*hooksV1alpha1.OnDefineDomainResult, error) {
-	log.Log.Info("Hook's OnDefineDomain callback method has been called")
+	log.Log.Info(onDefineDomainLoggingMessage)
 	newDomainXML, err := onDefineDomain(params.GetVmi(), params.GetDomainXML())
 	if err != nil {
 		return nil, err
@@ -93,7 +96,7 @@ func (s v1alpha1Server) OnDefineDomain(ctx context.Context, params *hooksV1alpha
 }
 
 func onDefineDomain(vmiJSON []byte, domainXML []byte) ([]byte, error) {
-	log.Log.Info("Hook's OnDefineDomain callback method has been called")
+	log.Log.Info(onDefineDomainLoggingMessage)
 
 	vmiSpec := vmSchema.VirtualMachineInstance{}
 	err := json.Unmarshal(vmiJSON, &vmiSpec)