network, e2e: Convert skipIfNotSupportedCluster() to a regular function

Currently, `skipIfNotSupportedCluster` is defined as an anonymous function. This function is not a closure [1], and could be defined as a regular function. [1] https://go.dev/tour/moretypes/25 Signed-off-by: Orel Misan <[email protected]>
zyjj1 · May 17, 2023 · a6cabc7 · a6cabc7
1 parent db8c797
commit a6cabc7
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/tests/network/expose.go b/tests/network/expose.go
@@ -90,18 +90,6 @@ var _ = SIGDescribe("[rfe_id:253][crit:medium][vendor:[email protected]][level:c
 		virtClient = kubevirt.Client()
 	})
 
-	skipIfNotSupportedCluster := func(ipFamily ipFamily) {
-		if includesIpv4(ipFamily) {
-			libnet.SkipWhenClusterNotSupportIpv4()
-		}
-		if inlcudesIpv6(ipFamily) {
-			libnet.SkipWhenClusterNotSupportIpv6()
-		}
-		if isDualStack(ipFamily) {
-			checks.SkipIfVersionBelow("Dual stack service requires v1.20 and above", "1.20")
-		}
-	}
-
 	appendIpFamilyToExposeArgs := func(ipFamily ipFamily, vmiExposeArgs []string) []string {
 		if inlcudesIpv6(ipFamily) {
 			vmiExposeArgs = append(vmiExposeArgs, "--ip-family", string(ipFamily))
@@ -777,6 +765,18 @@ func validateClusterIp(clusterIp string, ipFamily ipFamily) error {
 	return nil
 }
 
+func skipIfNotSupportedCluster(ipFamily ipFamily) {
+	if includesIpv4(ipFamily) {
+		libnet.SkipWhenClusterNotSupportIpv4()
+	}
+	if inlcudesIpv6(ipFamily) {
+		libnet.SkipWhenClusterNotSupportIpv6()
+	}
+	if isDualStack(ipFamily) {
+		checks.SkipIfVersionBelow("Dual stack service requires v1.20 and above", "1.20")
+	}
+}
+
 func getNodeHostname(nodeAddresses []k8sv1.NodeAddress) *string {
 	for _, address := range nodeAddresses {
 		if address.Type == k8sv1.NodeHostName {