forked from kubevirt/kubevirt
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request kubevirt#5354 from oshoval/move
tests, Move VMI lifecycle networking tests to network folder
- Loading branch information
Showing
3 changed files
with
132 additions
and
70 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
/* | ||
* This file is part of the kubevirt project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
* Copyright 2021 Red Hat, Inc. | ||
* | ||
*/ | ||
|
||
package network | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
|
||
expect "github.com/google/goexpect" | ||
|
||
. "github.com/onsi/ginkgo" | ||
. "github.com/onsi/gomega" | ||
|
||
k8sv1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
||
v1 "kubevirt.io/client-go/api/v1" | ||
"kubevirt.io/client-go/kubecli" | ||
"kubevirt.io/kubevirt/tests" | ||
"kubevirt.io/kubevirt/tests/console" | ||
cd "kubevirt.io/kubevirt/tests/containerdisk" | ||
"kubevirt.io/kubevirt/tests/libnet" | ||
) | ||
|
||
var _ = SIGDescribe("[crit:high][vendor:[email protected]][level:component]", func() { | ||
var err error | ||
var virtClient kubecli.KubevirtClient | ||
var vmi *v1.VirtualMachineInstance | ||
|
||
BeforeEach(func() { | ||
virtClient, err = kubecli.GetKubevirtClient() | ||
tests.PanicOnError(err) | ||
|
||
tests.BeforeTestCleanup() | ||
vmi = tests.NewRandomVMIWithEphemeralDisk(cd.ContainerDiskFor(cd.ContainerDiskAlpine)) | ||
}) | ||
|
||
Describe("[crit:high][vendor:[email protected]][level:component]Creating a VirtualMachineInstance", func() { | ||
Context("[Serial]when virt-handler is responsive", func() { | ||
It("VMIs with Bridge Networking shouldn't fail after the kubelet restarts", func() { | ||
bridgeVMI := vmi | ||
// Remove the masquerade interface to use the default bridge one | ||
bridgeVMI.Spec.Domain.Devices.Interfaces = nil | ||
bridgeVMI.Spec.Networks = nil | ||
v1.SetDefaults_NetworkInterface(bridgeVMI) | ||
Expect(bridgeVMI.Spec.Domain.Devices.Interfaces).NotTo(BeEmpty()) | ||
|
||
By("starting a VMI with bridged network on a node") | ||
bridgeVMI, err := virtClient.VirtualMachineInstance(tests.NamespaceTestDefault).Create(bridgeVMI) | ||
Expect(err).To(BeNil(), "Should submit VMI successfully") | ||
|
||
// Start a VirtualMachineInstance with bridged networking | ||
nodeName := tests.WaitForSuccessfulVMIStart(bridgeVMI) | ||
|
||
tests.VerifyDummyNicForBridgeNetwork(bridgeVMI) | ||
|
||
By("restarting kubelet") | ||
pod := renderPkillAllPod("kubelet") | ||
pod.Spec.NodeName = nodeName | ||
_, err = virtClient.CoreV1().Pods(tests.NamespaceTestDefault).Create(context.Background(), pod, metav1.CreateOptions{}) | ||
Expect(err).ToNot(HaveOccurred()) | ||
|
||
By("starting another VMI on the same node, to verify kubelet is running again") | ||
newVMI := tests.NewRandomVMIWithEphemeralDiskAndUserdata(cd.ContainerDiskFor(cd.ContainerDiskCirros), "#!/bin/bash\necho 'hello'\n") | ||
newVMI.Spec.NodeSelector = map[string]string{"kubernetes.io/hostname": nodeName} | ||
Eventually(func() error { | ||
newVMI, err = virtClient.VirtualMachineInstance(tests.NamespaceTestDefault).Create(newVMI) | ||
Expect(err).To(BeNil()) | ||
return nil | ||
}, 100, 10).Should(Succeed(), "Should be able to start a new VM") | ||
|
||
By("checking if the VMI with bridged networking is still running, it will verify the CNI didn't cause the pod to be killed") | ||
tests.WaitForSuccessfulVMIStart(bridgeVMI) | ||
}) | ||
|
||
It("VMIs with Bridge Networking should work with Duplicate Address Detection (DAD)", func() { | ||
bridgeVMI := tests.NewRandomVMIWithEphemeralDiskAndUserdata(cd.ContainerDiskFor(cd.ContainerDiskCirros), "#!/bin/bash\necho 'hello'\n") | ||
// Remove the masquerade interface to use the default bridge one | ||
bridgeVMI.Spec.Domain.Devices.Interfaces = nil | ||
bridgeVMI.Spec.Networks = nil | ||
v1.SetDefaults_NetworkInterface(bridgeVMI) | ||
Expect(bridgeVMI.Spec.Domain.Devices.Interfaces).NotTo(BeEmpty()) | ||
|
||
By("starting a VMI with bridged network on a node") | ||
bridgeVMI, err = virtClient.VirtualMachineInstance(vmi.Namespace).Create(bridgeVMI) | ||
Expect(err).To(BeNil(), "Should submit VMI successfully") | ||
|
||
// Start a VirtualMachineInstance with bridged networking | ||
By("Waiting the VirtualMachineInstance start") | ||
tests.WaitUntilVMIReady(bridgeVMI, console.LoginToCirros) | ||
tests.VerifyDummyNicForBridgeNetwork(bridgeVMI) | ||
|
||
// Update the VMI object so we get the IP address | ||
bridgeVMI, err = virtClient.VirtualMachineInstance(bridgeVMI.Namespace).Get(bridgeVMI.Name, &metav1.GetOptions{}) | ||
Expect(err).ToNot(HaveOccurred()) | ||
|
||
vmIP := libnet.GetVmiPrimaryIpByFamily(bridgeVMI, k8sv1.IPv4Protocol) | ||
dadCommand := fmt.Sprintf("sudo /usr/sbin/arping -D -I eth0 -c 2 %s | grep Received | cut -d ' ' -f 2\n", vmIP) | ||
|
||
Expect(console.SafeExpectBatch(bridgeVMI, []expect.Batcher{ | ||
&expect.BSnd{S: "\n"}, | ||
&expect.BExp{R: console.PromptExpression}, | ||
|
||
&expect.BSnd{S: dadCommand}, | ||
&expect.BExp{R: "0"}, | ||
}, 600)).To(Succeed()) | ||
}) | ||
}) | ||
}) | ||
}) | ||
|
||
func renderPkillAllPod(processName string) *k8sv1.Pod { | ||
return tests.RenderPrivilegedPod("vmi-killer", []string{"pkill"}, []string{"-9", processName}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -570,76 +570,6 @@ var _ = Describe("[rfe_id:273][crit:high][vendor:[email protected]][level:compon | |
|
||
tests.WaitForSuccessfulVMIStart(newVMI) | ||
}) | ||
|
||
It("VMIs with Bridge Networking shouldn't fail after the kubelet restarts", func() { | ||
bridgeVMI := vmi | ||
// Remove the masquerade interface to use the default bridge one | ||
bridgeVMI.Spec.Domain.Devices.Interfaces = nil | ||
bridgeVMI.Spec.Networks = nil | ||
v1.SetDefaults_NetworkInterface(bridgeVMI) | ||
Expect(bridgeVMI.Spec.Domain.Devices.Interfaces).NotTo(BeEmpty()) | ||
|
||
By("starting a VMI with bridged network on a node") | ||
bridgeVMI, err := virtClient.VirtualMachineInstance(tests.NamespaceTestDefault).Create(bridgeVMI) | ||
Expect(err).To(BeNil(), "Should submit VMI successfully") | ||
|
||
// Start a VirtualMachineInstance with bridged networking | ||
nodeName := tests.WaitForSuccessfulVMIStart(bridgeVMI) | ||
|
||
tests.VerifyDummyNicForBridgeNetwork(bridgeVMI) | ||
|
||
By("restarting kubelet") | ||
pod := renderPkillAllPod("kubelet") | ||
pod.Spec.NodeName = nodeName | ||
_, err = virtClient.CoreV1().Pods(tests.NamespaceTestDefault).Create(context.Background(), pod, metav1.CreateOptions{}) | ||
Expect(err).ToNot(HaveOccurred()) | ||
|
||
By("starting another VMI on the same node, to verify kubelet is running again") | ||
newVMI := newCirrosVMI() | ||
newVMI.Spec.NodeSelector = map[string]string{"kubernetes.io/hostname": nodeName} | ||
Eventually(func() error { | ||
newVMI, err = virtClient.VirtualMachineInstance(tests.NamespaceTestDefault).Create(newVMI) | ||
Expect(err).To(BeNil()) | ||
return nil | ||
}, 100, 10).Should(Succeed(), "Should be able to start a new VM") | ||
|
||
By("checking if the VMI with bridged networking is still running, it will verify the CNI didn't cause the pod to be killed") | ||
tests.WaitForSuccessfulVMIStart(bridgeVMI) | ||
}) | ||
|
||
It("VMIs with Bridge Networking should work with Duplicate Address Detection (DAD)", func() { | ||
bridgeVMI := tests.NewRandomVMIWithEphemeralDiskAndUserdata(cd.ContainerDiskFor(cd.ContainerDiskCirros), "#!/bin/bash\necho 'hello'\n") | ||
// Remove the masquerade interface to use the default bridge one | ||
bridgeVMI.Spec.Domain.Devices.Interfaces = nil | ||
bridgeVMI.Spec.Networks = nil | ||
v1.SetDefaults_NetworkInterface(bridgeVMI) | ||
Expect(bridgeVMI.Spec.Domain.Devices.Interfaces).NotTo(BeEmpty()) | ||
|
||
By("starting a VMI with bridged network on a node") | ||
bridgeVMI, err = virtClient.VirtualMachineInstance(vmi.Namespace).Create(bridgeVMI) | ||
Expect(err).To(BeNil(), "Should submit VMI successfully") | ||
|
||
// Start a VirtualMachineInstance with bridged networking | ||
By("Waiting the VirtualMachineInstance start") | ||
tests.WaitUntilVMIReady(bridgeVMI, console.LoginToCirros) | ||
tests.VerifyDummyNicForBridgeNetwork(bridgeVMI) | ||
|
||
// Update the VMI object so we get the IP address | ||
bridgeVMI, err = virtClient.VirtualMachineInstance(bridgeVMI.Namespace).Get(bridgeVMI.Name, &metav1.GetOptions{}) | ||
Expect(err).ToNot(HaveOccurred()) | ||
|
||
vmIP := libnet.GetVmiPrimaryIpByFamily(bridgeVMI, k8sv1.IPv4Protocol) | ||
dadCommand := fmt.Sprintf("sudo /usr/sbin/arping -D -I eth0 -c 2 %s | grep Received | cut -d ' ' -f 2\n", vmIP) | ||
|
||
Expect(console.SafeExpectBatch(bridgeVMI, []expect.Batcher{ | ||
&expect.BSnd{S: "\n"}, | ||
&expect.BExp{R: console.PromptExpression}, | ||
|
||
&expect.BSnd{S: dadCommand}, | ||
&expect.BExp{R: "0"}, | ||
}, 600)).To(Succeed()) | ||
}) | ||
|
||
}) | ||
|
||
Context("[Serial]when virt-handler is not responsive", func() { | ||
|