let developers specify api version

ref nov#74
zzip · Dec 4, 2014 · 25b445b · 25b445b
1 parent a2014db
commit 25b445b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/paypal.rb b/lib/paypal.rb
@@ -5,8 +5,9 @@
 require 'rest_client'
 
 module Paypal
+  cattr_accessor :api_version
+  self.api_version = '88.0'
 
-  API_VERSION = '88.0'
   ENDPOINT = {
     :production => 'https://www.paypal.com/cgi-bin/webscr',
     :sandbox => 'https://www.sandbox.paypal.com/cgi-bin/webscr'

diff --git a/lib/paypal/nvp/request.rb b/lib/paypal/nvp/request.rb
@@ -19,7 +19,7 @@ def self.endpoint
       end
 
       def initialize(attributes = {})
-        @version = API_VERSION
+        @version = Paypal.api_version
         super
       end
 

diff --git a/spec/paypal/nvp/request_spec.rb b/spec/paypal/nvp/request_spec.rb
@@ -36,7 +36,6 @@
 
       it 'should setup endpoint and version' do
         client = Paypal::NVP::Request.new attributes
-        client.version.should == Paypal::API_VERSION
         client.class.endpoint.should == Paypal::NVP::Request::ENDPOINT[:production]
       end
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ def self.endpoint @@
           end
           def initialize(attributes = {})
-            @version = API_VERSION
+            @version = Paypal.api_version
             super
           end
@@ Expand Down @@