Skip to content

Commit

Permalink
tests: Remove "test" from test names.
Browse files Browse the repository at this point in the history
Every test is a test, so each test doesn't need to attest to being a test.

Signed-off-by: Ben Pfaff <[email protected]>
Acked-by: Ryan Moats <[email protected]>
  • Loading branch information
blp committed Jun 10, 2016
1 parent 8135328 commit 1cece4a
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 30 deletions.
2 changes: 1 addition & 1 deletion tests/auto-attach.at
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
AT_BANNER([auto-attach unit tests])

AT_SETUP([auto-attach - packet tests])
AT_SETUP([auto-attach - packets])
AT_KEYWORDS([auto-attach])
AT_CHECK(ovstest test-aa, [], [ignore], [ignore])

Expand Down
44 changes: 22 additions & 22 deletions tests/library.at
Original file line number Diff line number Diff line change
@@ -1,77 +1,77 @@
AT_BANNER([library unit tests])

AT_SETUP([test flow extractor])
AT_SETUP([flow extractor])
AT_CHECK([$PERL `which flowgen.pl` >/dev/null 3>flows 4>pcap])
AT_CHECK([ovstest test-flows flows pcap], [0], [checked 247 packets, 0 errors
])
AT_CLEANUP

AT_SETUP([test TCP/IP checksumming])
AT_SETUP([TCP/IP checksumming])
AT_CHECK([ovstest test-csum], [0], [....#....#....####................................#................................#
])
AT_CLEANUP

AT_SETUP([test hash functions])
AT_SETUP([hash functions])
AT_CHECK([ovstest test-hash])
AT_CLEANUP

AT_SETUP([test hash map])
AT_SETUP([hash map])
AT_KEYWORDS([hmap])
AT_CHECK([ovstest test-hmap], [0], [............
])
AT_CLEANUP

AT_SETUP([test hash index])
AT_SETUP([hash index])
AT_KEYWORDS([hindex])
AT_CHECK([ovstest test-hindex], [0], [.....................
])
AT_CLEANUP

AT_SETUP([test cuckoo hash])
AT_SETUP([cuckoo hash])
AT_KEYWORDS([cmap])
AT_CHECK([ovstest test-cmap check 1], [0], [...
])
AT_CLEANUP

AT_SETUP([test counting cockoo hash])
AT_SETUP([counting cockoo hash])
AT_KEYWORDS([cmap])
AT_CHECK([ovstest test-ccmap check 1], [0], [...
])
AT_CLEANUP

AT_SETUP([test atomic operations])
AT_SETUP([atomic operations])
AT_CHECK([ovstest test-atomic])
AT_CLEANUP

AT_SETUP([test linked lists])
AT_SETUP([linked lists])
AT_CHECK([ovstest test-list], [0], [...
])
AT_CLEANUP

AT_SETUP([test packet library])
AT_SETUP([packet library])
AT_CHECK([ovstest test-packets])
AT_CLEANUP

AT_SETUP([test SHA-1])
AT_SETUP([SHA-1])
AT_CHECK([ovstest test-sha1], [0], [.........
])
AT_CLEANUP

AT_SETUP([test type properties])
AT_SETUP([type properties])
AT_CHECK([test-type-props])
AT_CLEANUP

AT_SETUP([test strtok_r bug fix])
AT_SETUP([strtok_r bug fix])
AT_CHECK([test-strtok_r], [0], [NULL NULL
])
AT_CLEANUP

AT_SETUP([test byte order conversion])
AT_SETUP([byte order conversion])
AT_KEYWORDS([byte order])
AT_CHECK([ovstest test-byte-order])
AT_CLEANUP

AT_SETUP([test random number generator])
AT_SETUP([random number generator])
AT_CHECK([ovstest test-random], [0], [dnl
average=7fa2014f

Expand Down Expand Up @@ -142,7 +142,7 @@ m4_foreach(
AT_CHECK([ovstest test-util testname], [0], [], [])
AT_CLEANUP])

AT_SETUP([test unix socket, short pathname - C])
AT_SETUP([unix socket, short pathname - C])
AT_SKIP_IF([test "$IS_WIN32" = "yes"])
AT_CHECK([ovstest test-unix-socket x])
AT_CLEANUP
Expand All @@ -152,7 +152,7 @@ dnl go in a fixed-length field in struct sockaddr_un. Generally the limit
dnl is about 100 bytes. On Linux, we work around this by indirecting through
dnl a directory fd using /proc/self/fd/<dirfd>. We do not have a workaround
dnl for other platforms, so we skip the test there.
AT_SETUP([test unix socket, long pathname - C])
AT_SETUP([unix socket, long pathname - C])
AT_SKIP_IF([test "$IS_WIN32" = "yes"])
dnl Linux sockaddr_un has a 108-byte limit, so this needs to be longer.
dnl Linux "ecryptfs" has a 143-byte limit, so we use that many bytes.
Expand All @@ -166,7 +166,7 @@ AT_CHECK([cd $longname && ovstest test-unix-socket ../$longname/socket socket])
AT_CLEANUP

m4_define([UNIX_SOCKET_SHORT_PATHNAME_PYN],
[AT_SETUP([test unix socket, short pathname - $1])
[AT_SETUP([unix socket, short pathname - $1])
AT_SKIP_IF([test $2 = no || test "$IS_WIN32" = "yes"])
AT_KEYWORDS([python unixsocket])
AT_CHECK([$3 $srcdir/test-unix-socket.py x])
Expand All @@ -181,7 +181,7 @@ dnl is about 100 bytes. On Linux, we work around this by indirecting through
dnl a directory fd using /proc/self/fd/<dirfd>. We do not have a workaround
dnl for other platforms, so we skip the test there.
m4_define([UNIX_SOCKET_LONG_PATHNAME_PYN],
[AT_SETUP([test unix socket, long pathname - $1])
[AT_SETUP([unix socket, long pathname - $1])
AT_SKIP_IF([test $2 = no || test "$IS_WIN32" = "yes"])
AT_KEYWORDS([python unixsocket])
dnl Linux sockaddr_un has a 108-byte limit, so this needs to be longer.
Expand Down Expand Up @@ -224,7 +224,7 @@ AT_SETUP([snprintf])
AT_CHECK([ovstest test-util snprintf])
AT_CLEANUP

AT_SETUP([test bitmap functions])
AT_SETUP([bitmap functions])
AT_CHECK([ovstest test-bitmap check], [0], [..
])
AT_CLEANUP
Expand All @@ -233,10 +233,10 @@ AT_SETUP([use of public headers])
AT_CHECK([test-lib], [0], [])
AT_CLEANUP

AT_SETUP([test ofpbuf module])
AT_SETUP([ofpbuf module])
AT_CHECK([ovstest test-ofpbuf], [0], [])
AT_CLEANUP

AT_SETUP([test rcu])
AT_SETUP([rcu])
AT_CHECK([ovstest test-rcu-quiesce], [0], [])
AT_CLEANUP
12 changes: 6 additions & 6 deletions tests/ovn-controller-vtep.at
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ AT_CHECK([ovn-nbctl lport-set-options $2 vtep-physical-switch=$3 vtep-logical-sw
##############################################

# tests chassis related updates.
AT_SETUP([ovn-controller-vtep - test chassis])
AT_SETUP([ovn-controller-vtep - chassis])
OVN_CONTROLLER_VTEP_START

# verifies the initial ovn-sb db configuration.
Expand Down Expand Up @@ -178,7 +178,7 @@ AT_CLEANUP


# Tests binding updates.
AT_SETUP([ovn-controller-vtep - test binding 1])
AT_SETUP([ovn-controller-vtep - binding 1])
OVN_CONTROLLER_VTEP_START

# adds logical switch 'lswitch0' and vlan_bindings.
Expand Down Expand Up @@ -242,7 +242,7 @@ AT_CLEANUP

# Tests corner case: Binding the vtep logical switch from two different
# datapath.
AT_SETUP([ovn-controller-vtep - test binding 2])
AT_SETUP([ovn-controller-vtep - binding 2])
OVN_CONTROLLER_VTEP_START

# adds logical switch 'lswitch0' and vlan_bindings.
Expand Down Expand Up @@ -281,7 +281,7 @@ AT_CLEANUP


# Tests vtep module vtep logical switch tunnel key update.
AT_SETUP([ovn-controller-vtep - test vtep-lswitch])
AT_SETUP([ovn-controller-vtep - vtep-lswitch])
OVN_CONTROLLER_VTEP_START

# creates the logical switch in vtep and adds the corresponding logical
Expand Down Expand Up @@ -333,7 +333,7 @@ AT_CLEANUP


# Tests vtep module 'Ucast_Macs_Remote's.
AT_SETUP([ovn-controller-vtep - test vtep-macs 1])
AT_SETUP([ovn-controller-vtep - vtep-macs 1])
OVN_CONTROLLER_VTEP_START

# creates a simple logical network with the vtep device and a fake hv chassis
Expand Down Expand Up @@ -404,7 +404,7 @@ AT_CLEANUP


# Tests vtep module 'Ucast_Macs_Remote's (corner cases).
AT_SETUP([ovn-controller-vtep - test vtep-macs 2])
AT_SETUP([ovn-controller-vtep - vtep-macs 2])
OVN_CONTROLLER_VTEP_START

# creates a simple logical network with the vtep device and a fake hv chassis
Expand Down
2 changes: 1 addition & 1 deletion tests/ovn-sbctl.at
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ AT_CLEANUP

dnl ---------------------------------------------------------------------

AT_SETUP([ovn-sbctl - test])
AT_SETUP([ovn-sbctl])
OVN_SBCTL_TEST_START

AT_CHECK([ovn-nbctl lswitch-add br-test])
Expand Down

0 comments on commit 1cece4a

Please sign in to comment.