Skip to content

Commit

Permalink
PHOENIX-4975 Addendum to fix failing unit tests for Omid due to shado…
Browse files Browse the repository at this point in the history
…w cells and no local indexes
  • Loading branch information
JamesRTaylor committed Oct 23, 2018
1 parent 72d6109 commit 0c28ea2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,12 @@ public StatsEnabledSplitSystemCatalogIT(String transactionProvider) {
this.tableDDLOptions = optionBuilder.toString();
}

@Parameters(name = "transactional = {0}")
public static Collection<Object> data() {
return Arrays.asList(new Object[] { null, "TEPHRA", "OMID" });
@Parameters(name = "transactionProvider = {0}")
public static Collection<Object[]> data() {
return TestUtil.filterTxParamData(Arrays.asList(new Object[][] {
{ "TEPHRA" },
{ "OMID" },
{ null }}),0);
}

@BeforeClass
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ public void testRowCountAndByteCounts() throws SQLException {
// an exact byte count based on the number or rows is not possible because
// it is variable on a row-by-row basis.
long sumOfGuidePostsWidth = rs.getLong(3);
assertTrue(hasShadowCells ? sumOfGuidePostsWidth > 2 * c2Bytes && sumOfGuidePostsWidth <= 3 * c2Bytes: rs.getLong(3) == c2Bytes);
assertTrue(hasShadowCells ? sumOfGuidePostsWidth > c2Bytes : sumOfGuidePostsWidth == c2Bytes);
count++;
}
}
Expand Down

0 comments on commit 0c28ea2

Please sign in to comment.