Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: Merges changes from wpcom as of 17th of June, 2015 #2264

Closed
wants to merge 3 commits into from
Closed

Sharing: Merges changes from wpcom as of 17th of June, 2015 #2264

wants to merge 3 commits into from

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Jun 17, 2015

This is a merge of several changes from wpcom. cc @aduth

dereksmart and others added 3 commits June 17, 2015 14:19
@dereksmart @zinigor
Post Flair: merged the code from Jetpack in order to synchronize chan…
93d15c0 
…ges.

This commit includes several changesets that are explained in detail in the following posts:
https://[private link]
https://[private link]
https://[private link]
https://[private link]
https://[private link]

Merges r119521-wpcom.
@zinigor
Sharing Buttons: Pinterest: Use "One Image" Pin It button type
9f9f99e 
Previously used "Any Image" (`buttonBookmark`) type, which is confusing in the context of a front page where many posts exist (and may not include the actual post for which the Pin It button is rendered).

This change will attempt to find an appropriate image to Pin from the post, falling back to Blavatars/Gravatars, and finally a blank image (or filtered value via Jetpack filter).

See: https://[private link]
See: https://github.com/Automattic/io/issues/374

Merges r118317-wpcom.
@zinigor
Sharing Buttons: Pinterest: Enabling overriding of widget type
f4b4d84 
Allowing site owners to choose to override the default `buttonPin` single-image widget type.

See: r118317
See: https://github.com/Automattic/io/issues/374#issuecomment-104190565

Merges r118401-wpcom.
@zinigor zinigor added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 17, 2015
@zinigor zinigor added this to the 3.6 milestone Jun 17, 2015
@dereksmart
Copy link
Member

LGTM aside from what jeremy pointed out

@aduth
Copy link
Contributor

aduth commented Jun 17, 2015

Thanks for porting these over, @zinigor . The changes to sharing-sources.php look good to me, and were confirmed to be working in my Jetpack environment. I'm now noticing that non-official styles don't use the same behavior as the official button (affects both Jetpack and WordPress.com).

@aduth
Copy link
Contributor

aduth commented Jun 17, 2015

See the merge/sharedaddy-leftovers-consistency branch for an attempt at providing consistent behavior between the official and non-official buttons (specifically, 22521f4).

@zinigor zinigor mentioned this pull request Jun 18, 2015
Merged
@zinigor
Copy link
Member Author

zinigor commented Jun 18, 2015

Closing this in favor of #2269

@zinigor zinigor closed this Jun 18, 2015
@zinigor zinigor removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 18, 2015
@zinigor zinigor deleted the merge/sharedaddy-leftovers branch June 18, 2015 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Sharing Post sharing, sharing buttons [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@zinigor @dereksmart @aduth @jeherve