Sharing: merges the changes from wpcom as of 18th of June, 2015 #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used "Any Image" (`buttonBookmark`) type, which is confusing in the context of a front page where many posts exist (and may not include the actual post for which the Pin It button is rendered). This change will attempt to find an appropriate image to Pin from the post, falling back to Blavatars/Gravatars, and finally a blank image (or filtered value via Jetpack filter). See: https://[private link] See: https://github.com/Automattic/io/issues/374 Merges r118317-wpcom.
Allowing site owners to choose to override the default `buttonPin` single-image widget type. See: r118317 See: https://github.com/Automattic/io/issues/374#issuecomment-104190565 Merges r118401-wpcom.
Previously, only official buttons would render the single image view. This updates non-official button styles to use the same singular image view, and similarly respects the filter to override in case “Any Image” type is desired.
zinigor
added
[Type] Enhancement
|
Pushed e80aff7 to simplify the JavaScript snippet insertion, since the stats should already be tracked when the user navigates to the share action (via Tested to be working on my test environment, both official and non-official styles, and with/without a filter to override the widget type to |
|
Read the code and tested as well, everything looks good to me! |
zinigor
added
[Status] Ready to Merge
|
LGTM 👍 |
dereksmart
added a commit
that referenced
this pull request
Jun 19, 2015
…onsistency Sharing: merges the changes from wpcom as of 18th of June, 2015
dereksmart
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #2264.