Social: Unified connections management #40679

manzoorwanijk · 2024-12-19T08:26:27Z

Proposed changes:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Just check the connections management in Jetpack
Confirm that it loads fine
Confirm that you can add, remove and update connections
Confirm that the authors can do the same
Check the editor on Simple and Atomic sites
Check the Jetpack Settings > Sharing section on Atomic sites
~~Test Social | Enable connections management for WPCOM sites #41019 as that contains these changes.~~

github-actions · 2024-12-19T08:27:21Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the social/unified-connections-management branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack social/unified-connections-management

bin/jetpack-downloader test jetpack-mu-wpcom-plugin social/unified-connections-management

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-12-19T08:27:32Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for February 4, 2025 (scheduled code freeze on February 4, 2025).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

* Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php

* Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php

* Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition

* Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog

* Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]>

* WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]>

)

pablinos

I've done quite a bit of testing with this now, and apart from the known issue, which is also in trunk, I haven't had any problems.

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs --------- Co-authored-by: Paul Bunkham <[email protected]>

manzoorwanijk closed this Dec 19, 2024

manzoorwanijk force-pushed the social/unified-connections-management branch from 2d2dbd8 to 56c0fbc Compare December 19, 2024 08:26

github-actions bot added the [Status] In Progress label Dec 19, 2024

manzoorwanijk reopened this Dec 19, 2024

manzoorwanijk added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Dec 19, 2024

manzoorwanijk self-assigned this Dec 19, 2024

github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components [Status] In Progress RNA [Package] Publicize and removed [Status] In Progress labels Dec 19, 2024

manzoorwanijk force-pushed the social/unified-connections-management branch 2 times, most recently from a749a20 to 9af33a7 Compare December 26, 2024 05:12

manzoorwanijk force-pushed the social/unified-connections-management branch from 9af33a7 to 4af0cc4 Compare January 7, 2025 05:01

github-actions bot added the [Tests] Includes Tests label Jan 7, 2025

manzoorwanijk added 7 commits January 8, 2025 16:50

Merge branch 'trunk' into social/unified-connections-management

3a5ee5f

Merge branch 'trunk' into social/unified-connections-management

74f0c07

Merge branch 'trunk' into social/unified-connections-management

f705911

Merge branch 'trunk' into social/unified-connections-management

e058b84

github-actions bot added the [JS Package] Script Data label Jan 10, 2025

manzoorwanijk and others added 2 commits January 10, 2025 23:11

Merge branch 'trunk' into social/unified-connections-management

a7dd133

manzoorwanijk and others added 16 commits January 15, 2025 10:12

Merge branch 'trunk' into social/unified-connections-management

67f14a2

Unify changelogs

afac4c1

Unify js changelog

4d13e1b

It should be 'blog' not 'site'

c27ef5c

Merge branch 'trunk' into social/unified-connections-management

4fbe10b

Merge branch 'trunk' into social/unified-connections-management

280d472

Merge branch 'trunk' into social/unified-connections-management

0d97db1

Social | Use the proxy trait from connection package (#41087)

565eaa1

Merge branch 'trunk' into social/unified-connections-management

1ce1b4c

Merge branch 'trunk' into social/unified-connections-management

13ac87f

Update baseline.php

bc569d6

Merge branch 'trunk' into social/unified-connections-management

1fabbd2

Merge branch 'trunk' into social/unified-connections-management

ec6091b

Update phan

d5ba310

Social | Fix social connections list initial state feature check (#41151

423e5ed

)

github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin labels Jan 20, 2025

manzoorwanijk changed the title ~~Social: Base PR: Unified connections management~~ Social: Unified connections management Jan 20, 2025

pablinos approved these changes Jan 20, 2025

View reviewed changes

manzoorwanijk merged commit ca6c8b1 into trunk Jan 21, 2025
78 of 80 checks passed

manzoorwanijk deleted the social/unified-connections-management branch January 21, 2025 02:55

github-actions bot removed [Status] In Progress [Status] Needs Team Review labels Jan 21, 2025

manzoorwanijk mentioned this pull request Jan 21, 2025

Fix TS error in trunk #41200

Merged

3 tasks

pablinos mentioned this pull request Jan 21, 2025

Revert "Social | Improve and fix TS types for connection actions and selectors" #41221

Closed

manzoorwanijk mentioned this pull request Jan 21, 2025

Fix Social E2E tests Automattic/wp-calypso#98683

Merged

8 tasks

ciampo mentioned this pull request Jan 21, 2025

E2E: temporarily skip broken Social: Editor Features tests Automattic/wp-calypso#98686

Closed

8 tasks

manzoorwanijk mentioned this pull request Jan 22, 2025

Publicize | Fix PHP unit tests #41237

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Social: Unified connections management #40679

Social: Unified connections management #40679

manzoorwanijk commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

pablinos left a comment

Social: Unified connections management #40679

Social: Unified connections management #40679

Conversation

manzoorwanijk commented Dec 19, 2024 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 19, 2024 • edited Loading

pablinos left a comment

Choose a reason for hiding this comment

manzoorwanijk commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading