Redirect admin interface from default to classic style #98664

madhusudhand · 2025-01-21T11:14:58Z

Related to #98193

🚨 DO NOT MERGE 🚨
Depends on: Automattic/jetpack#40913

Proposed Changes

Redirect admin interface from default to classic style when the experiment calypso_post_onboarding_holdout_120924 is enabled.

Testing Instructions

Visit default view of the general settings page https://wordpress.com/settings/general/:site
It should load calypso view (the below experiment is not enabled.)
Assign yourself to the experiment calypso_post_onboarding_holdout_120924
Visit the same page again. Now it should redirect to /wp-admin/options-general.php
test the same for following settings pages
- reading
- writing
- discussions

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-01-21T11:16:32Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131587

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131587&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131587&env=a8c-for-agencies

matticbot · 2025-01-21T12:33:30Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~39 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
settings-discussion        +35 B  (+0.0%)      +11 B  (+0.0%)
settings-writing           +32 B  (+0.0%)       +8 B  (+0.0%)
settings-reading           +32 B  (+0.0%)      +11 B  (+0.0%)
settings                   +32 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

client/controller/index.web.js

mmtr · 2025-01-22T09:14:02Z

the experiment calypso_post_onboarding_holdout_120924

Heads-up that the experiment recently changed to calypso_post_onboarding_holdout_160125, we no longer use the calypso_post_onboarding_holdout_120924 one since it had to be disabled.

lsl · 2025-01-22T22:36:33Z

Heads-up that the experiment recently changed to calypso_post_onboarding_holdout_160125, we no longer use the calypso_post_onboarding_holdout_120924 one since it had to be disabled.

Thanks, we'll patch this before deploying. Adding DO NOT MERGE label to note that we need to also merge Automattic/jetpack#40913 at the same-ish time as well as a few things before these.

mmtr · 2025-01-23T10:09:33Z

we'll patch this before deploying

No need to patch anything in the code, it already uses the correct experiment :) My comment was just referring to the experiment mentioned in the PR summary and testing instructions, so if you strictly follow them, you won't be able to test this PR.

matticbot · 2025-01-31T02:23:44Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

blaze-dashboard
command-palette-wp-admin
help-center
notifications
odyssey-stats
whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug redirect/default-to-classic-interface on your sandbox.

lsl · 2025-02-03T03:18:34Z

Merged into #98875

) * PoC * Tidy up the styles * /sites/settings/administration -> /sites/settings/site * Add "Admin interface style" to General Settings * Redirect /settings/general to /sites/settings/site * Hide settings sidebar for simple sites * Introduce `useRemoveDuplicateViewsExperimentEnabled` * Update flags * Update flags in controllers * Update flags in components * Fix type error * Remove Admin interface style Revert "Add "Admin interface style" to General Settings" This reverts commit b0caa4b. * Use PanelCard instead of HostingCard * Don't use wide Panel card * Proper switching b/w /hosting-feature <-> /hosting-config - Switching to Atomic while on /hosting-feature: Redirect to /hosting-config/:site - Switching to Simple while on /hosting-config: Redirect to /sites/settings/site/:site * Remove the notice for staging sites * Remove /settings/general -> /sites/settings/site redirection * Revert "Remove /settings/general -> /sites/settings/site redirection" This reverts commit 2d5d325. * Limit re-instated /settings/general/:site redirect to classic view only * Redirect if the user is not admin * Add redirects to wp-admin based on #98664 * Fix unexpected redirection to options-general.php * Redirect /settings to site settings if in treatment group * Remove redirects * Move settings redirects to local controller * Typo --------- Co-authored-by: Louis Laugesen <[email protected]>

madhusudhand self-assigned this Jan 21, 2025

madhusudhand mentioned this pull request Jan 21, 2025

Move admin interface style mutation to common file #98665

Closed

8 tasks

madhusudhand force-pushed the redirect/default-to-classic-interface branch from a9b7028 to c1eeccd Compare January 21, 2025 12:23

madhusudhand force-pushed the redirect/default-to-classic-interface branch from 79bf79b to 9f19b49 Compare January 21, 2025 12:44

madhusudhand added 3 commits January 22, 2025 11:26

redirect settings routes from default to classic interface

165936f

add redirect wrapper for untangling settings experiment

cb4a35e

make aaTestName optional

63ac0fd

madhusudhand force-pushed the redirect/default-to-classic-interface branch from 9f19b49 to 63ac0fd Compare January 22, 2025 05:56

madhusudhand requested a review from mmtr January 22, 2025 06:35

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 22, 2025

madhusudhand requested a review from a team January 22, 2025 06:35

madhusudhand marked this pull request as ready for review January 22, 2025 06:35

update experiment name

51fcb69

mmtr reviewed Jan 22, 2025

View reviewed changes

client/controller/index.web.js Outdated Show resolved Hide resolved

revert new wrapper for redirects

bfd264e

lsl added the DO NOT MERGE label Jan 22, 2025

taipeicoder unassigned madhusudhand Jan 24, 2025

lsl added 3 commits January 29, 2025 14:45

Merge branch 'trunk' into redirect/default-to-classic-interface

80295fe

Merge branch 'trunk' into redirect/default-to-classic-interface

3f2892d

Merge branch 'trunk' into redirect/default-to-classic-interface

afdc936

okmttdhr mentioned this pull request Jan 31, 2025

Make Site Settings available to duplicate views experiment users #98875

Merged

8 tasks

lsl changed the base branch from trunk to add/hosting-menu-site-setting January 31, 2025 04:46

lsl changed the base branch from add/hosting-menu-site-setting to trunk January 31, 2025 05:04

lsl added a commit that referenced this pull request Feb 3, 2025

Add redirects to wp-admin based on #98664

146f6d7

lsl closed this Feb 3, 2025

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2025

okmttdhr mentioned this pull request Feb 5, 2025

Add settings page redirects to wp-admin for duplicate view experiment #99321

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redirect admin interface from default to classic style #98664

Redirect admin interface from default to classic style #98664

madhusudhand commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited by matticbot

Loading

matticbot commented Jan 21, 2025 •

edited

Loading

mmtr commented Jan 22, 2025

lsl commented Jan 22, 2025

mmtr commented Jan 23, 2025 •

edited

Loading

matticbot commented Jan 31, 2025

lsl commented Feb 3, 2025

Redirect admin interface from default to classic style #98664

Redirect admin interface from default to classic style #98664

Conversation

madhusudhand commented Jan 21, 2025 • edited Loading

Proposed Changes

Testing Instructions

Pre-merge Checklist

github-actions bot commented Jan 21, 2025 • edited by matticbot Loading

matticbot commented Jan 21, 2025 • edited Loading

mmtr commented Jan 22, 2025

lsl commented Jan 22, 2025

mmtr commented Jan 23, 2025 • edited Loading

matticbot commented Jan 31, 2025

lsl commented Feb 3, 2025

madhusudhand commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited by matticbot

Loading

matticbot commented Jan 21, 2025 •

edited

Loading

mmtr commented Jan 23, 2025 •

edited

Loading