Make Site Settings available to duplicate views experiment users #98875

okmttdhr · 2025-01-24T08:12:14Z

Related to #98185, pfYzsZ-1uU-p2

Not strictly blocking but should be merged with Automattic/jetpack#40913 at a similar time.

Proposed Changes

This PR makes "Site Settings" available to duplicate views experiment users.

URL	Simple	Atomic
`/sites/settings/site/:site`
`/hosting-config/:site`	Redirect to `/hosting-features`:
`/sites/settings/site/:site/transfer-site`
`/sites/settings/site/:site/reset-site`
`/sites/settings/site/:site/delete-site`
`/settings/general/:site`	Redirect to `/sites/settings/site/:site` on Classic, Redirect to options-general.php on Default with #98664	Redirect to `/sites/settings/site/:site` on Classic, Redirect to options-general.php on Default with #98664
`/settings/start-over/:site`	Redirect to `/sites/settings/site/:site/reset-site`	Redirect to `/sites/settings/site/:site/reset-site`
`/settings/start-site-transfer/:site`	Redirect to `/sites/settings/site/:site/transfer-site`	Redirect to `/sites/settings/site/:site/transfer-site`
`/settings/delete-site/:site`	Redirect to `/sites/settings/site/:site/delete-site`	Redirect to `/sites/settings/site/:site/delete-site`

This PR removes the Admin Interface setting from Server Settings, and we won't have the Admin Interface setting anywhere in SMP. i.e., the Admin Interface setting can only be found in /wp-admin/options-general.php.

While it might make sense to move this WordPress.com-specific setting in SMP, the original intent of adding it under Settings → General was to provide HEs and users with a single, consistent location to modify the setting—regardless of the admin interface style or page-specific view.
Once the hold-out phase is over, adding the Admin Interface setting to SMP would align with this goal, as users will always have access to SMP.

Redirection logic:

Classic view + hold out
- /settings/general (Hosting > Site Settings) redirects to SMP since they are compatible feature-wise.
- Users can access options-general.php via Settings > General as before.
Default view + hold out
- /settings/general (Settings > General) redirects to options-general.php
- /settings/reading (Settings > General) redirects to options-reading.php
- /settings/writing (Settings > General) redirects to options-writing.php
- /settings/discussion (Settings > General) redirects to options-discussion.php

p1738292995924339/1738285330.573259-slack-CRWCHQGUB

Why are these changes being made?

See #98185 and pfYzsZ-1uU-p2.

This PR focuses on adopting the new design's structure. We will address styling details in later iterations soon:
pfYzsZ-1uU-p2#comment-1452.

Testing Instructions

Add yourself to the treatment group via 22167-explat-experiment
Go to /sites
Select any site
Click the "Settings" tab
Test if functions work propery as much as possible
Test links are correct as much as possible
Test all the redirections work as expected

Regression testing:

Add yourself to the control group via 22167-explat-experiment
Go to /sites
- Select any site
- Click the "Server Settings" tab
- Ensure the page works properly
Go to /settings/general/:site (Settings > General in Default site, Hosting > Site Settings in Classic sites)
- Ensure the page works properly

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-01-24T08:12:26Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-132059

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-132059&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-132059&env=a8c-for-agencies

client/sites/components/site-preview-pane/dotcom-preview-pane.tsx

matticbot · 2025-01-24T08:22:07Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~129 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         -350 B  (-0.0%)     -165 B  (-0.0%)
entry-stepper               -350 B  (-0.0%)     -166 B  (-0.0%)
entry-domains-landing       -350 B  (-0.1%)     -165 B  (-0.1%)
entry-browsehappy           -350 B  (-0.2%)     -165 B  (-0.3%)
entry-login                  +96 B  (+0.0%)       -4 B  (-0.0%)
entry-main                   -12 B  (-0.0%)     -128 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~8179 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
hosting                 +185595 B  (+6.7%)   +49161 B  (+6.6%)
staging-site              -7004 B  (-0.4%)    -2811 B  (-0.6%)
settings                  -2088 B  (-0.2%)     -562 B  (-0.2%)
site-settings             +1185 B  (+0.1%)     -310 B  (-0.1%)
settings-newsletter        +599 B  (+0.1%)     +916 B  (+0.6%)
settings-discussion        +599 B  (+0.1%)     +811 B  (+0.7%)
settings-writing           +461 B  (+0.1%)     +110 B  (+0.1%)
settings-security          +461 B  (+0.1%)     +113 B  (+0.1%)
settings-reading           +461 B  (+0.1%)     +105 B  (+0.1%)
settings-podcast           +461 B  (+0.1%)     +110 B  (+0.1%)
settings-performance       +461 B  (+0.1%)     +145 B  (+0.1%)
settings-jetpack           +461 B  (+0.1%)     +156 B  (+0.1%)
site-marketing             +341 B  (+0.0%)     +105 B  (+0.0%)
marketing                  +332 B  (+0.0%)      +50 B  (+0.0%)
email                      +103 B  (+0.0%)      -48 B  (-0.0%)
site-tools                  -69 B  (-0.0%)     -318 B  (-0.1%)
github-deployments          -69 B  (-0.0%)     +140 B  (+0.0%)
people                      -58 B  (-0.0%)     -476 B  (-0.2%)
site-purchases              +13 B  (+0.0%)      +11 B  (+0.0%)
purchases                   +13 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

client/my-sites/site-settings/form-general.jsx

client/sites/settings/index.tsx

client/hosting/overview/controller.tsx

fushar · 2025-01-29T07:33:25Z

client/my-sites/site-settings/form-jetpack-monitor.jsx

@@ -86,11 +86,12 @@ class SiteSettingsFormJetpackMonitor extends Component {

 		/* eslint-disable wpcalypso/jsx-classname-namespace */
 		return (
-			<PanelCard className="jetpack-monitor-settings">
+			<HostingCard


I'm curious why we changed many PanelCard back to HostingCard in this PR?

The idea was to deprecate HostingCard and start using PanelCard in the new design.

I tried reverting the changes in this file (and the defensive mode card) and I didn't notice any broken visual.

If we use PanelCard, there will be inconsistent spacing because the other HostingCard has an extra margin-bottom.

In production, this isn't an issue since we're using Masonry, but this PR removes it to align them vertically. https://github.com/Automattic/wp-calypso/pull/98875/files#diff-907edd6df95246780ac004e4382376a1337c383d5623336379d74a2e44707ab8R195

I reverted the change in 011e592, and I believe we can keep using PanelCard for now, as we're exploring the layout design (card, one-column, two-column) TvapEJxLZ98RGWobNN1Xd1-fi-487_10437 and addressing it soon. CC: @matt-west

matt-west

Added a minor comment about making the width of the settings cards consistent across tabs.

Why do we display the Admin interface style card here now?

lsl

Mostly works great, I came across a couple of issues:

This might be ok but I would expect the admin interface switcher not to redirect to wp-admin when modifying this option in SMP.
Switching to a staging site while on settings results in errors,
2a. Clicking server settings subtab results in a broken back button
Switching to a simple site while on server settings takes you to hosting features instead of General settings (One could argue this is correct but I expected to stay in the settings tab)

Peek.2025-01-30.11-15.mp4

Revert "Add "Admin interface style" to General Settings" This reverts commit b0caa4b.

okmttdhr · 2025-01-30T02:24:04Z

Thanks for the feedback!

Why do we display the Admin interface style card here now?

This might be ok but I would expect the admin interface switcher not to redirect to wp-admin when modifying this option in SMP.

After discussion, I removed the Admin Interface setting from SMP.

Added the following context in the description: 👇

This PR removes the Admin Interface setting from Server Settings, and we won't have the Admin Interface setting anywhere in SMP. i.e., the Admin Interface setting can only be found in /wp-admin/options-general.php.

While it might make sense to move this WordPress.com-specific setting in SMP, the original intent of adding it under Settings → General was to provide HEs and users with a single, consistent location to modify the setting—regardless of the admin interface style or page-specific view.

Once the hold-out phase is over, adding the Admin Interface setting to SMP would align with this goal, as users will always have access to SMP.

Slack convo: p1738198428731869/1738195548.078849-slack-CRWCHQGUB

okmttdhr · 2025-01-30T02:41:49Z

Switching to a simple site while on server settings takes you to hosting features instead of General settings (One could argue this is correct but I expected to stay in the settings tab)

I checked our latest design, and the Hosting Features tab is separate from the Settings tab:

I believe this itself makes sense since it will keep this upsell prominent.

So, I think I suggest keeping users within the Settings tab when switching to a simple site while on Settings > Server. That feels more intuitive. Thoughts? @matt-west @lsl

fushar

Tested both control and treatment behaviors. It works nicely 👍

matt-west · 2025-01-30T11:39:11Z

I'd prefer to redirect Server Settings to the general settings instead of the hosting features page

Agreed. 👍

This reverts commit 2d5d325.

lsl · 2025-02-03T03:21:12Z

client/my-sites/site-settings/settings-controller.js

@@ -58,7 +61,7 @@ export function siteSettings( context, next ) {
 	}
 	recordPageView( basePath + '/:site', analyticsPageTitle );

-	next();
+	redirectIfDuplicatedView( 'options-general.php' )( context, next );


Needed to happen after the above redirect checks so running the extra middleware here instead of in the controller like all the others.

matticbot · 2025-02-03T04:07:16Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/hosting-menu-site-setting on your sandbox.

lsl

Tested without the wp-admin redirects:

Treatment:

Simple site Classic view
Simple site Default view
Atomic site Classic view
Atomic site Default view

Control:

Simple site Classic view
Simple site Default view
Atomic site Classic view
Atomic site Default view

Everything looks good / makes sense.

okmttdhr commented Jan 24, 2025

View reviewed changes

client/sites/components/site-preview-pane/dotcom-preview-pane.tsx Outdated Show resolved Hide resolved

okmttdhr commented Jan 24, 2025

View reviewed changes

client/my-sites/site-settings/form-general.jsx Outdated Show resolved Hide resolved

PoC

7523772

okmttdhr self-assigned this Jan 28, 2025

okmttdhr added 2 commits January 28, 2025 14:44

Tidy up the styles

39582ad

/sites/settings/administration -> /sites/settings/site

8cbf951

okmttdhr force-pushed the add/hosting-menu-site-setting branch from 4641a1b to 8cbf951 Compare January 28, 2025 06:04

okmttdhr added 4 commits January 28, 2025 15:42

Add "Admin interface style" to General Settings

b0caa4b

Redirect /settings/general to /sites/settings/site

6d0b384

Hide settings sidebar for simple sites

59b3f47

Introduce useRemoveDuplicateViewsExperimentEnabled

ed7797f

okmttdhr commented Jan 28, 2025

View reviewed changes

client/sites/settings/index.tsx Show resolved Hide resolved

okmttdhr added 3 commits January 29, 2025 09:47

Update flags

df844ff

Update flags in controllers

3a346a8

Update flags in components

45ecba9

okmttdhr force-pushed the add/hosting-menu-site-setting branch from 9eed548 to 45ecba9 Compare January 29, 2025 02:47

Fix type error

b3f42b6

okmttdhr marked this pull request as ready for review January 29, 2025 05:41

okmttdhr requested a review from a team January 29, 2025 05:48

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 29, 2025

okmttdhr requested a review from matt-west January 29, 2025 05:52

fushar reviewed Jan 29, 2025

View reviewed changes

matt-west reviewed Jan 29, 2025

View reviewed changes

lsl reviewed Jan 30, 2025

View reviewed changes

Remove Admin interface style

fee6dae

Revert "Add "Admin interface style" to General Settings" This reverts commit b0caa4b.

Use PanelCard instead of HostingCard

011e592

okmttdhr requested a review from a team January 30, 2025 08:12

fushar reviewed Jan 30, 2025

View reviewed changes

fushar approved these changes Jan 30, 2025

View reviewed changes

lsl and others added 5 commits January 31, 2025 13:56

Revert "Remove /settings/general -> /sites/settings/site redirection"

01a1719

This reverts commit 2d5d325.

Limit re-instated /settings/general/:site redirect to classic view only

684b29e

Merge branch 'trunk' into add/hosting-menu-site-setting

d480d73

Redirect if the user is not admin

525d893

Add redirects to wp-admin based on #98664

146f6d7

lsl mentioned this pull request Feb 3, 2025

Redirect admin interface from default to classic style #98664

Closed

8 tasks

lsl reviewed Feb 3, 2025

View reviewed changes

Merge branch 'trunk' into add/hosting-menu-site-setting

88a86a6

lsl mentioned this pull request Feb 3, 2025

Remove Jetpack Carousel settings tests for calypso #99197

Merged

This was referenced Feb 3, 2025

Add Site Management Panel link to General Settings page Automattic/jetpack#41497

Merged

Fix Site Visibility link for duplicated view experiment users Automattic/jetpack#41531

Merged

lsl and others added 6 commits February 5, 2025 12:21

Merge branch 'trunk' into add/hosting-menu-site-setting

0336157

Fix unexpected redirection to options-general.php

2ad25f1

Redirect /settings to site settings if in treatment group

b560f6f

Remove redirects

127a54d

Move settings redirects to local controller

40d4d9e

Merge branch 'trunk' into add/hosting-menu-site-setting

52254bb

lsl approved these changes Feb 5, 2025

View reviewed changes

Typo

eefccda

okmttdhr merged commit ad30aad into trunk Feb 5, 2025
13 checks passed

okmttdhr deleted the add/hosting-menu-site-setting branch February 5, 2025 06:41

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 5, 2025

okmttdhr mentioned this pull request Feb 5, 2025

Add settings page redirects to wp-admin for duplicate view experiment #99321

Merged

8 tasks

lsl mentioned this pull request Feb 5, 2025

Include query params in start-site-transfer redirect #99383

Merged

okmttdhr mentioned this pull request Feb 10, 2025

Redirect to /settings/general if the RDV experiment is DISABLED #99528

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Site Settings available to duplicate views experiment users #98875

Make Site Settings available to duplicate views experiment users #98875

okmttdhr commented Jan 24, 2025 •

edited by lsl

Loading

github-actions bot commented Jan 24, 2025 •

edited by matticbot

Loading

matticbot commented Jan 24, 2025 •

edited

Loading

fushar Jan 29, 2025

okmttdhr Jan 30, 2025 •

edited

Loading

matt-west left a comment

lsl left a comment

okmttdhr commented Jan 30, 2025 •

edited

Loading

okmttdhr commented Jan 30, 2025 •

edited

Loading

fushar left a comment

matt-west commented Jan 30, 2025

lsl Feb 3, 2025

matticbot commented Feb 3, 2025 •

edited

Loading

lsl left a comment •

edited

Loading

Make Site Settings available to duplicate views experiment users #98875

Make Site Settings available to duplicate views experiment users #98875

Conversation

okmttdhr commented Jan 24, 2025 • edited by lsl Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented Jan 24, 2025 • edited by matticbot Loading

matticbot commented Jan 24, 2025 • edited Loading

fushar Jan 29, 2025

Choose a reason for hiding this comment

okmttdhr Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

matt-west left a comment

Choose a reason for hiding this comment

lsl left a comment

Choose a reason for hiding this comment

okmttdhr commented Jan 30, 2025 • edited Loading

okmttdhr commented Jan 30, 2025 • edited Loading

fushar left a comment

Choose a reason for hiding this comment

matt-west commented Jan 30, 2025

lsl Feb 3, 2025

Choose a reason for hiding this comment

matticbot commented Feb 3, 2025 • edited Loading

lsl left a comment • edited Loading

Choose a reason for hiding this comment

okmttdhr commented Jan 24, 2025 •

edited by lsl

Loading

github-actions bot commented Jan 24, 2025 •

edited by matticbot

Loading

matticbot commented Jan 24, 2025 •

edited

Loading

okmttdhr Jan 30, 2025 •

edited

Loading

okmttdhr commented Jan 30, 2025 •

edited

Loading

okmttdhr commented Jan 30, 2025 •

edited

Loading

matticbot commented Feb 3, 2025 •

edited

Loading

lsl left a comment •

edited

Loading