update ps with network SDK with Network 11.1.0 #4265

DeepakRajendranMsft · 2017-07-06T22:57:09Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

DeepakRajendranMsft · 2017-07-06T22:58:17Z

@markcowl @shahabhijeet @cormacpayne this is the PR to increase the network sdk

DeepakRajendranMsft · 2017-07-06T23:23:11Z

on demand run: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1735/console

DeepakRajendranMsft · 2017-07-07T01:06:08Z

http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1736/

DeepakRajendranMsft · 2017-07-07T01:14:07Z

http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1737/

DeepakRajendranMsft · 2017-07-07T07:32:19Z

On-demand build succeeded: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1739/console

Type related changes

markcowl · 2017-07-07T20:16:39Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

@@ -600,10 +600,18 @@
      <Project>{70527617-7598-4aef-b5bd-db9186b8184b}</Project>
      <Name>Commands.Common.Authentication.Abstractions</Name>
    </ProjectReference>
+    <ProjectReference Include="..\..\..\Common\Commands.Common.Authentication\Commands.Common.Authentication.csproj">


Do not add this reference. You should only have a reference to the abstractions class.

markcowl · 2017-07-07T20:30:27Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

    <ProjectReference Include="..\..\..\Common\Commands.Common\Commands.Common.csproj">
      <Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
      <Name>Commands.Common</Name>
    </ProjectReference>
+    <ProjectReference Include="..\..\Common\Commands.Common.Authentication.ResourceManager\Commands.Common.Authentication.ResourceManager.csproj">


Do not add this reference. You may need to build this as part of your solution, but it cannot be a dependency of your management cmdlets

markcowl · 2017-07-07T20:36:02Z

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

It looks like none of these changes should be necessary

…/azure-powershell into UpdateNrpSdk

DeepakRajendranMsft · 2017-07-07T21:43:26Z

src/ResourceManager/Network/Commands.Network/Models/PSIpFlowVerify.cs

-        public uint Protocol { get; set; }
-        public uint RemoteIPAddress { get; set; }
-        public uint RemotePort { get; set; }
+        public int Protocol { get; set; }


this file is not even being used... should be removed. will check with Irina and follow up

Yes, the file can be removed

markcowl · 2017-07-07T22:27:38Z

on demand run here: http://azuresdkci.cloudapp.net/job/powershell-demand/1742/

akshaysngupta · 2017-07-07T22:34:13Z

LGTM

DeepakRajendranMsft · 2017-07-08T00:12:45Z

on demand run : http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1743/

update ps with network SDK

34d6696

msftclas added the cla-not-required label Jul 6, 2017

azuresdkci added the needs-review label Jul 6, 2017

azuresdkci assigned markcowl Jul 6, 2017

update ulong to long/

8f92531

update ulong to long?

32a7af4

DeepakRajendranMsft added 2 commits July 6, 2017 18:48

update ulong to long?

200c1ce

update breaking changes.csv

759c7da

akshaysngupta and others added 5 commits July 7, 2017 12:00

type related changes

5e382f8

reverting deploymentparam json

0eab6fc

swtich to if to ignopre case

f3caa1d

removing space

65de3d2

Merge pull request #6 from akshaysngupta/preview

87b1070

Type related changes

henry416 mentioned this pull request Jul 7, 2017

VPN Client Protocols for Virtual Network Gateways #4251

Closed

13 tasks

markcowl requested changes Jul 7, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels Jul 7, 2017

markcowl assigned DeepakRajendranMsft and unassigned markcowl Jul 7, 2017

DeepakRajendranMsft added 3 commits July 7, 2017 14:00

update breaking change issue.csv

9c69f2d

Merge branch 'UpdateNrpSdk' of https://github.com/DeepakRajendranMsft…

32815b8

…/azure-powershell into UpdateNrpSdk

remove unused proj references'

47e820c

DeepakRajendranMsft commented Jul 7, 2017

View reviewed changes

markcowl previously approved these changes Jul 7, 2017

View reviewed changes

Update vnet gateway properties

7ae15ff

DeepakRajendranMsft dismissed markcowl’s stale review via 7ae15ff July 7, 2017 22:42

lamchester approved these changes Jul 7, 2017

View reviewed changes

markcowl merged commit 42b838b into Azure:release-4.2.0 Jul 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update ps with network SDK with Network 11.1.0 #4265

update ps with network SDK with Network 11.1.0 #4265

DeepakRajendranMsft commented Jul 6, 2017 •

edited by azuresdkci

Loading

DeepakRajendranMsft commented Jul 6, 2017

DeepakRajendranMsft commented Jul 6, 2017

DeepakRajendranMsft commented Jul 7, 2017

DeepakRajendranMsft commented Jul 7, 2017

DeepakRajendranMsft commented Jul 7, 2017

markcowl Jul 7, 2017

DeepakRajendranMsft Jul 7, 2017

markcowl Jul 7, 2017

DeepakRajendranMsft Jul 7, 2017

markcowl Jul 7, 2017

DeepakRajendranMsft Jul 7, 2017

irrogozh Jul 7, 2017

markcowl commented Jul 7, 2017

akshaysngupta commented Jul 7, 2017

DeepakRajendranMsft commented Jul 8, 2017

update ps with network SDK with Network 11.1.0 #4265

update ps with network SDK with Network 11.1.0 #4265

Conversation

DeepakRajendranMsft commented Jul 6, 2017 • edited by azuresdkci Loading

Description

DeepakRajendranMsft commented Jul 6, 2017

DeepakRajendranMsft commented Jul 6, 2017

DeepakRajendranMsft commented Jul 7, 2017

DeepakRajendranMsft commented Jul 7, 2017

DeepakRajendranMsft commented Jul 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markcowl commented Jul 7, 2017

akshaysngupta commented Jul 7, 2017

DeepakRajendranMsft commented Jul 8, 2017

DeepakRajendranMsft commented Jul 6, 2017 •

edited by azuresdkci

Loading