Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditions on enchantments applied to creatures silently fail with no message #78597

Open
Standing-Storm opened this issue Dec 16, 2024 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Standing-Storm
Copy link
Contributor

Describe the bug

Testing #78586 and the modifications to the slowing spells I applied did nothing. Further testing showed that enchants applied to monsters always evaluate conditions to false, even something that should always be true like 1 == 1 or u_is_monster

Attach save file

N/A, requires modification (at the moment)

Steps to reproduce

  1. Put the following JSON in your game somewhere so it loads:

{
"type": "effect_type",
"id": "effect_frozen_monster",
"name": [ "Super Slow" ],
"desc": [ "This monster is unbelievably slow!" ],
"show_in_info": true,
"enchantments": [
{
"condition": "u_is_monster",
"values": [
{
"value": "SPEED",
"add": -1000
}
]
}
]
}

  1. Using the debug menu, apply this effect to a monster
  2. Monster's speed is not reduced.

Expected behavior

Ideally, conditions work. In the meantime, an error message to appear.

Screenshots

Untitled2

Untitled2

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.4460 (23H2)
  • Game Version: 42c3aed [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Magiclysm [magiclysm]
    ]

Additional context

No response

@Standing-Storm Standing-Storm added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 16, 2024
@GuardianDll
Copy link
Member

// Dialogue conditions for monsters seems like overkill.
// Definitely not an excuse for not knowing how to add them. Nope! Sure isn't!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

2 participants