Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helpers #1

Merged
merged 48 commits into from
Jun 27, 2020
Merged

feat: add helpers #1

merged 48 commits into from
Jun 27, 2020

Conversation

desivi
Copy link
Member

@desivi desivi commented Jun 27, 2020

This PR adds helpers for Eveble framework.


Review Checklist

Basics

  • PR information has been filled
  • PR has been assigned
  • PR uses appropriate labels (feature/chore/style/docs/refactor/perf/test)
  • PR has a good description that summarizes all changes
  • PR is updated to the most recent version of the target branch(and there are no conflicts)
  • PR scope(size) is manageable(feat: add helpers #1 way to speed up review time)
  • PR is peer reviewed optional
  • Commits contain a meaningful commit messages and fallow syntax of Conventional Commits
  • On dependency change: yarn.lock file is updated and committed
  • CHANGELOG.md and references to project's version are unchanged(let semantic-release do the magic)

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with TypeScript
  • Code builds(yarn build)
  • Code is formatted(yarn test:format)
  • Code is linted(yarn test:lint)
  • Code is unit tested(yarn test:unit)
  • Code is integration tested(yarn test:integration)
  • Required code coverage specification is met

Testing

  • New feature/change is covered by unit tests
  • New feature/change is covered by integration tests
  • All existing tests are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done optional

@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant